-
-
Notifications
You must be signed in to change notification settings - Fork 8.3k
lib/pico-sdk: Update to version 2.1.1. #16783
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Note sure if this should be part of our upcoming 1.25.0 release or not, but it does fix quite a few bugs in pico-sdk. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #16783 +/- ##
=======================================
Coverage 98.54% 98.54%
=======================================
Files 169 169
Lines 21855 21855
=======================================
Hits 21536 21536
Misses 319 319 ☔ View full report in Codecov by Sentry. |
Code size report:
|
6150394
to
bced897
Compare
Judging by some of the bugs it fixes I would be tempted to say yes. There's only so much more Pico WiFi weirdness we can suffer! Though pragmatically speaking it's probably cutting it a bit close? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like a pretty safe update to me, and will open the door to rolling back some of our timer workarounds after 1.25.0
I've now done a thorough test of this PR on:
Running the test suite, native tests, multitests, WLAN and BLE tests. I did not find any regressions in these tests compared to master. |
Release notes: https://github.com/raspberrypi/pico-sdk/releases/tag/2.1.1 Signed-off-by: Damien George <[email protected]>
bced897
to
13b0237
Compare
Summary
Update pico-sdk to the just-release patch version 2.1.1 (we are currently at 2.1.0).
See pico-sdk release notes: https://github.com/raspberrypi/pico-sdk/releases/tag/2.1.1
Testing
Ran the full test suite on a RPI_PICO_W and it looks OK.
Edit: did full tests of RPI_PICO, RPI_PICO_W, RPI_PICO2, RPI_PICO2_W (the latter two both in ARM and RISCV) mode, testing all things covered by the test suite including WLAN and BLE. No regressions were found.