extmod/asyncio/stream.py: Add ipv6 support to start_server(). #17311
+234
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #17311 +/- ##
=======================================
Coverage 98.54% 98.54%
=======================================
Files 169 169
Lines 21898 21898
=======================================
Hits 21579 21579
Misses 319 319 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
3443947 to
56e8e68
Compare
|
Code size report: |
56e8e68 to
6227c48
Compare
Enhance network interface discovery in test framework: - Add get_host_ipv6() function to determine host IPv6 address - Update test template to include IPv6 address lookup - Add helper method for IPv6 IP address retrieval from network interfaces - Support modern interface address format (ifconfig with address type) Signed-off-by: Andrew Leech <[email protected]>
Ensures that the underlying socket is opened with the correct protocol as parsed by getaddrinfo(). Signed-off-by: Andrew Leech <[email protected]>
6227c48 to
3b17ecc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I'm starting to use ipv6 more with micropython devices as their discoverability can actually be much better on a local network, without worrying about needing to manually configure (ipv4) ip addresses.
To that end, this PR adds support to start_server() to automatically use the parsed protocol, ie setting
socket.AF_INETorsocket.AF_INET6on the socket as parsed bygetaddrinfo()When adding unit tests for this change, I found the multi-test runner was missing support for ipv6 ip address detection, so that's been added as well (in a separate commit)
The ip address detection in multi-test runner has also been updated to use the newer / preferred
network.ipconfig("addr4")style interface by default, falling back to ipconfig if needed.Testing
Unit tests are included which check ipv6 support in both
net_hostedstyle test andmult_nettests.Without the change to
extmod/asyncio/stream.pythe tests fails withOSError: 97Trade-offs and Alternatives