WIP py/objtype: Implement __call__ handling for instance w/o heap alloc. #2633
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@dpgeorge , did you know that calling
__call__
on instances always leads to heap alloc? The code was originally implemented in such way by me. As you can see, the patch is awful, it duplicates code in objboundmeth.c, etc.Why mp_call_function_n_kw() wasn't originally implemented in such a way as to require a slot for self at the beginning of args, then skip it if not needed? Unless there were good reasons, let's refactor that now ;-).