Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

pfalcon
Copy link
Contributor

@pfalcon pfalcon commented May 14, 2019

Based on the git history, for modules I initially created or made substantial contributions to.

@pfalcon
Copy link
Contributor Author

pfalcon commented May 14, 2019

This PR also includes #4363 , which got ignored for more than a half-year now.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is the ordered changed here (and elsewhere)? Since 2013 is earlier than 2014 it makes sense to retain the order.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed order in files which were initially created by me. I hope you would agree that it makes sense if the original author were listed first.

Also, arguably, your copyright year would be adjusted to match the real history of a file, and if you remember, I did that once in a previous patchset on this matter, but refrained from doing this again, as ultimately, you're the best party to maintain your copyright notice.

(Finally, many copyright notices in files contributed by me in early period get your copyright mostly by cut-n-paste, with rationalization that while I create some module from scratch, the structure of it is governed (and copied) from your substantial effort. While later it became clear that it doesn't scale to have any MicroPython-related file ever written to include your copyright, I obviously don't try to revision notices added at that early time.)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, you're right that this file looks to be completely fresh (or at least fresh enough) at its time of creation. So I should adjust my year to match the history.

@dpgeorge
Copy link
Member

Is it intended to update axtls?

Paul Sokolovsky added 2 commits May 15, 2019 10:45
Based on the git history, for modules I initially created or made
substantial contributions to.

Change-Id: Ic10a33c6b33f6210bb73ea3625d296f202fda906
…oject.

Change-Id: Id40cab51cc51048771ae0799e2a12ccae1d22eb5
@pfalcon
Copy link
Contributor Author

pfalcon commented May 15, 2019

Is it intended to update axtls?

Definitely not, rebased.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, you're right that this file looks to be completely fresh (or at least fresh enough) at its time of creation. So I should adjust my year to match the history.

*
* The MIT License (MIT)
*
* Copyright (c) 2014-2017 Paul Sokolovsky
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok

*
* The MIT License (MIT)
*
* Copyright (c) 2014-2018 Paul Sokolovsky
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok

*
* The MIT License (MIT)
*
* Copyright (c) 2014-2017 Paul Sokolovsky
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok

*
* The MIT License (MIT)
*
* Copyright (c) 2014 Paul Sokolovsky
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok

*
* The MIT License (MIT)
*
* Copyright (c) 2015 Paul Sokolovsky
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok

@dpgeorge
Copy link
Member

I merged the main commit here in 016d9a4, and a follow up in 653e175

For the change to LICENSE, that was not merged and can be discussed further in #4363

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants