mpy-cross: Do not automatically build mpy-cross, rather do it manually. #4825
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Building mpy-cross automatically leads to some issues with the build process and slows it down. Instead, require it to be built manually.
|
+1 |
|
Merged in 4173950 |
17 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building mpy-cross automatically leads to some issues with the build process and slows it down (see eg #3255, #3987, #4733). Instead, require it to be built manually.
mpy-cross is pretty stable now, and well known by users, so I think it's only a minor inconvenience to require it to be built manually (roughly once each release), and this is a simple way to fix a lot of problems with having it auto-built.