extmod/uwebsocket: Support masked transmissions and handling of PING requests #6732
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fee75da to
966b1d6
Compare
The websocket specification requires that clients mask data going to the server. rfc6455 has more details.
966b1d6 to
5960d54
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add the essential client side features (response to PING requests and payload masking on transmission) to the uwebsocket module to allow micropython targets to use client side websockets.
A previous PR (#3406) was opened to address this but appears to be abandoned. Issues that were brought up there have been addressed here outside of the request around non-blocking writes. Ideally, this could be handled as a separate PR.