Thanks to visit codestin.com
Credit goes to github.com

Skip to content

RP2: Enable bluetooth support and add Nimble port. #7561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

RP2: Enable bluetooth support and add Nimble port. #7561

wants to merge 3 commits into from

Conversation

iabdalkader
Copy link
Contributor

No description provided.

@iabdalkader iabdalkader mentioned this pull request Jul 22, 2021
Closed
@iabdalkader iabdalkader force-pushed the rp2_bluetooth branch 2 times, most recently from 1791d63 to 89380ba Compare July 22, 2021 13:02
@codecov-commenter
Copy link

codecov-commenter commented Jul 22, 2021 •
edited
Loading

Codecov Report

Merging #7561 (c330382) into master (a367529) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7561      +/-   ##
==========================================
+ Coverage   98.27%   98.28%   +0.01%     
==========================================
  Files         154      154              
  Lines       19994    19994              
==========================================
+ Hits        19650    19652       +2     
+ Misses        344      342       -2
Impacted Files Coverage Δ
py/obj.c 96.82% <0.00%> (+0.79%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a367529...c330382. Read the comment docs.

@iabdalkader
Copy link
Contributor Author

I think maybe it was a bad idea to include a change to extmod in the same PR because it triggers a build of all ports. Should I move that to a separate PR ? I need to add a mp_bluetooth_hci_uart_any to mpbthci.h so that controller drivers (in /drivers) can read, write and poll uart without having to use a specific uart driver.

@iabdalkader iabdalkader force-pushed the rp2_bluetooth branch 3 times, most recently from c330382 to 87022b4 Compare August 6, 2021 13:00
@iabdalkader
Copy link
Contributor Author

@dpgeorge Can I get feedback on this PR ? Would you prefer to keep this BT HCI driver in drivers or a board dir ? Also I have another PR queued up to add networking support to RP2 port, and the WiFi driver for the same module.

@iabdalkader iabdalkader force-pushed the rp2_bluetooth branch 2 times, most recently from 8301bb1 to e0b3b10 Compare August 15, 2021 16:34
@iabdalkader iabdalkader mentioned this pull request Aug 15, 2021
Closed
12 tasks
@iabdalkader iabdalkader force-pushed the rp2_bluetooth branch 2 times, most recently from 3b0d77b to cb23c04 Compare August 16, 2021 01:17
@iabdalkader
extmod/mpbthci.h: Add uart_any prototype.
2338f94 
* This allows drivers to use mpbthciport functions to read/write/poll uart.
@iabdalkader
extmod/nimble.cmake: Add nimble CMake file.
e9df829
dpgeorge
dpgeorge reviewed Sep 19, 2021
View reviewed changes
@dpgeorge
Copy link
Member

Would you prefer to keep this BT HCI driver in drivers or a board dir ?

I'm not sure what you mean. What's included in this PR now is nice and clean, there are no drivers.

@iabdalkader
Copy link
Contributor Author

I'm not sure what you mean. What's included in this PR now is nice and clean, there are no drivers.

I'm not sure either, I think at some point this also included the WiFi/BT module (Nina) BT HCI driver, then I moved it to another PR.

dpgeorge
dpgeorge approved these changes Sep 19, 2021
View reviewed changes
Copy link
Member

@dpgeorge dpgeorge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to go.

@dpgeorge
Copy link
Member

Merged in 80f2c79 through c973cfd

@dpgeorge dpgeorge closed this Sep 19, 2021
@iabdalkader iabdalkader deleted the rp2_bluetooth branch September 19, 2021 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dpgeorge dpgeorge dpgeorge approved these changes

Assignees
No one assigned
Labels
port-rp2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@iabdalkader @codecov-commenter @dpgeorge