py/lexer.c: Clear fstring_args vstr on lexer free. #7679
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jim Mussared <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #7679 +/- ##
=======================================
Coverage 98.25% 98.25%
=======================================
Files 154 154
Lines 20071 20071
=======================================
Hits 19721 19721
Misses 350 350
Continue to review full report at Codecov.
|
|
Thanks, merged in 5555f14 |
tannewt
pushed a commit
to tannewt/circuitpython
that referenced
this pull request
Mar 21, 2023
be more careful when setting socket to non-blocking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I missed this in #7649 -- it's not strictly necessary as the GC will clean it anyway, but it's good to pre-emptively gc_free() all the blocks used in lexing/parsing.
+8 bytes on PYBV11.