stm32/mpconfigport.h: Use the EXTRA feature level. #7958
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #7958 +/- ##
==========================================
- Coverage 98.25% 98.24% -0.01%
==========================================
Files 154 154
Lines 20007 20007
==========================================
- Hits 19657 19656 -1
- Misses 350 351 +1
Continue to review full report at Codecov.
|
e03d9c5 to
ebb2a03
Compare
Some of these will later be moved to CORE or BASIC, but EXTRA is a good starting point based on what STM32 uses. Signed-off-by: Jim Mussared <[email protected]>
The idea is to make this a no-op change. Future improvements can come from making individual boards use CORE or BASIC. Signed-off-by: Jim Mussared <[email protected]>
No-op change to simplify existing config. Signed-off-by: Jim Mussared <[email protected]>
ebb2a03 to
d8a3486
Compare
tannewt
added a commit
to tannewt/circuitpython
that referenced
this pull request
May 11, 2023
Add board.DISPLAY to hack_club_sprig
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuing on from #7655, this now updates mpconfig.h to make anything included by default on STM32 enabled at the
EXTRAlevel, updates STM32 to useEXTRA, and removes any redundant config fromstm32/mpconfigport.h.Same for rp2, but with some additional customisations left in
rp2/mpconfigport.h(these should be investigated in a future PR).Note that many of the flags in
mpconfig.hthat have been set to EXTRA will end up being upgraded to CORE or BASIC (as we figure out what those boards are).