extmod: Revert accidental usocket->socket rename. #8684
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #8684 +/- ##
=======================================
Coverage 98.23% 98.23%
=======================================
Files 154 154
Lines 20334 20334
=======================================
Hits 19975 19975
Misses 359 359 Continue to review full report at Codecov.
|
|
Thanks. usocket is back at the mimxrt ports, and the tests that failed or were skipped for that reason now pass. |
This was referenced May 20, 2022
|
Thanks, merged in 75efb32 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Raised by @robert-hh here #8566 (comment)
The registration of the
usocketmodule was accidentally changed tosocketin the move toMP_REGISTER_MODULEin bb794f0.