esp32: make I2C more efficient by using write-then-read transfers #8718
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This option is useful for ports where it's more efficient to do a full I2C transfer in one go. Signed-off-by: Damien George <[email protected]>
I2C transfers are much more efficient if they are combined, instead of doing separate writes and reads. Fixes issue micropython#7134. Signed-off-by: Damien George <[email protected]>
b0b7e3a to
6bda80d
Compare
|
I tested this on an ESP32S2 with IDF 4.4.1, doing a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an alternative to #8682 that just improves the I2C transfer function for ports that need it, eg esp32.
This addresses #7134, and also #8135 (even though that is now fixed in a newer IDF version).