Thanks to visit codestin.com
Credit goes to github.com

Skip to content

docs/library/time.rst: fix description of return results in time.mktime() #9221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lowfatcode
Copy link

@lowfatcode lowfatcode commented Sep 6, 2022

Currently it states that the result is the number of seconds since
Jan 1, 2000 - however at least on RP2040 that isn't the case
and further up the same page of documentation it is stated that
the epoch is usually Jan 1, 1970.

Currently it states that the result is the number of seconds since Jan 1, 2000 - however at least on RP2040 that isn't the case and further up the same page of documentation it is stated that the epoch is usually Jan 1, 1970.
@lowfatcode lowfatcode changed the title Fix description of return results in time.mktime() docs/library/time.rst: fix description of return results in time.mktime() Sep 6, 2022
@jimmo
Copy link
Member

jimmo commented Sep 8, 2022

Thanks @lowfatcode

This is something we'd like to fix for MicroPython 2.0 :)

Rather than duplicating the same information that's elsewhere on the page, might be better to just say

"It returns an integer which is the number of seconds since the epoch"

where "the epoch" is a link to the "Note:" in the third paragraph at the top which explains this in more detail.

@dpgeorge dpgeorge added the docs label Nov 7, 2022
RetiredWizard pushed a commit to RetiredWizard/micropython that referenced this pull request May 16, 2024
[Tooling] Add `--list` to `circuitpython_setboard`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants