Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Adding Pin.toggle() to docs #9653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Adding Pin.toggle() to docs #9653

wants to merge 1 commit into from

Conversation

millosolomillo
Copy link

Pin.toggle() works with the pyboard and the Raspberry Pi Pico (RP2040), so I am adding the method to the documentation.

Apparently it is not working with the ESP32 port #8789, so feel free to move it under this section:

The following methods are not part of the core Pin API and only implemented on certain ports.

@millosolomillo millosolomillo closed this by deleting the head repository Oct 17, 2022
@robert-hh
Copy link
Contributor

But since pin.toggle() exists on some ports, it can be documented, with a note listing the ports which have it.

@robert-hh robert-hh reopened this Oct 17, 2022
@robert-hh
Copy link
Contributor

But the commit message format is wrong. It could be for instance:
docs: Add the documentation for Pin.toggle().

@dpgeorge dpgeorge added the docs label Oct 25, 2022
@dpgeorge
Copy link
Member

It looks like the fork that this PR was made from has been deleted. So I'll close this PR. Someone else can open another with this change if they want to, but please put it in the section "The following methods are not part of the core API".

@dpgeorge dpgeorge closed this Nov 15, 2022
RetiredWizard pushed a commit to RetiredWizard/micropython that referenced this pull request Sep 24, 2024
Fix infinite loop when there's a partial frame at the end of the file.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants