-
Notifications
You must be signed in to change notification settings - Fork 1k
python-ecosys/urequests: Rename module to requests. #540
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
iabdalkader
commented
Sep 27, 2022
- Modules in python-ecosys should provide compatible versions of modules from the larger Python ecosystem, with u-prefix this is not true.
(Summarising conversation from Discord) Agree that we should do this, but need to figure out a backwards compatibility story.
So the second point is the main concern. I think for better or worse, we have to continue to freeze something that can be imported with "import urequests" for the forseeable future. Here are some ideas:
Similar story for |
I just don't think there should be a
|
With the suggested change for removing u for builtins with alias to previous u names, is it worth considering having the alias handled in import rather than case by case? I'm wary of ever adding such broad "magic" but in this case maybe it's worth it to simplify the clean up of so many different kinds of module names? |
We still see lots of people talking about the esp8266 port in the forum and get occasional bug reports too.
Unlike rp2, the esp32 (and esp8266) manifest includes urequests at the port level, and therefore all boards. We can't have some boards have "requests" and some boards have "urequests". We need to make "import urequests" continue to work on esp32/esp8266 for the foreseeable future.
This might be a good option. It will mean that That said, I think my preference is for the second option that I proposed above...
The only downside is that there's an extra I think the same approach works for asyncio too. |
* Modules in python-ecosys should provide compatible versions of modules from the larger Python ecosystem, with u-prefix this is not true.
dfc770b
to
062f828
Compare
Okay I've updated this PR to include |
I thought about this some more, and I think I'd rather go with the first option.
Implemented this in #702 |
Renamed in 8513bfb |