[UWP] Set background image tile control to IsEnabled false to avoid generating extraneous tab stops#3778
Merged
Merged
Conversation
…enerating extraneous tab stops
|
Nice catch. How did you find it? #Resolved |
|
This non-spec pull request has had no recent activity for the past 5 days . Please take the necessary actions (review, address feedback or commit if reviewed already) to move this along. #Resolved |
jwoo-msft
approved these changes
Feb 19, 2020
|
Thanks for reviewing this previously stale pull request. Resetting staleness. #Resolved |
Contributor
Author
|
Saw a comment somewhere that this repro'd whenever there was a background image, which pointed me at the thing hosting the background images (TileControl). Since that inherits from Control, it needs to be marked as not enabled if it's not interactive otherwise it will generate a tab stop. In reply to: 585551792 [](ancestors = 585551792) |
RebeccaAnne
pushed a commit
that referenced
this pull request
Feb 26, 2020
…enerating extraneous tab stops (#3778)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
Fixes #3777
Description
The additional tab stop is caused by the custom TileControl which hosts the background image. Because this is not intended as an interactive control, set IsEnabled to false to remove the tab stop.
How Verified
Manually verified additional tab stop is no longer present using AdaptiveCard.BackgroundImage.FillMode.Cover.json
Microsoft Reviewers: Open in CodeFlow