ActionSet refactoring & Extra View Removal.#3818
Conversation
* have and width and height constraint * fix test 1 * some update and fixed for bug * fixed actionset clipping issue * Updated vertical * updated for CR
| inputs, | ||
| acoElem, | ||
| config, | ||
| handleActionFallbackException(exception, superview, rootView, inputs, acoElem, config, |
There was a problem hiding this comment.
if all the other changes were to change the parameters to be arranged vertically, why is this one to make the parameters arranged horizontally? #Resolved
There was a problem hiding this comment.
this is done by clang-format according to Apple Coding style.
In reply to: 387950316 [](ancestors = 387950316)
| ACOFeatureRegistration *featureReg = [ACOFeatureRegistration getInstance]; | ||
|
|
||
| UIView<ACRIContentHoldingView> *childview = nil; | ||
| UIStackView *childview = [[UIStackView alloc] init]; |
There was a problem hiding this comment.
why was the previous design using some of our custom views? what advantages does changing to a UIStackview has? #Resolved
There was a problem hiding this comment.
we don't need custom view's extra feature. stock UIStackView is sufficient to get the job done.
In reply to: 387950942 [](ancestors = 387950942)
|
|
||
| if (ActionsOrientation::Horizontal == adaptiveActionConfig.actionsOrientation) { | ||
| childview = [[ACRColumnSetView alloc] initWithFrame:CGRectMake(0, 0, superview.frame.size.width, superview.frame.size.height) attributes:attributes]; | ||
| ((ACRColumnSetView *)childview).isActionSet = YES; |
There was a problem hiding this comment.
what other parts of the code use the isActionSet property? is it still a good idea to keep this flag existing for something else? #Resolved
There was a problem hiding this comment.
This is for layoutsubview method to readjust the action set; this task is handled by ACRContentHoldingUIScrollView atm, but the code can be still used if we others use containing view to the custom view.
In reply to: 387951641 [](ancestors = 387951641)
| } | ||
|
|
||
| if (isDeficientInWidth and isDeficientInWidth) { | ||
| if (isDeficientInWidth and isDeficientInHeight) { |
There was a problem hiding this comment.
isn't this change in other PR too? #Resolved
There was a problem hiding this comment.
yes, it was added by cherry-pick; shouldn't matter though as the conflict can be resolved.
In reply to: 387951953 [](ancestors = 387951953)
* have and width and height constraint * fix test 1 * some update and fixed for bug * fixed actionset clipping issue * Updated vertical * updated for CR
Fixed ActionSet having extra height.
This is a back port from release/1.2 branch.
Related Issue
fixed #3784
Description
There was an extra view between base elements and actions causing the view's expansion.
How Verified
Verified that extra view was removed.
Worked with the Teams mobile to confirm it.
Microsoft Reviewers: Open in CodeFlow