Fixed action set cut off issue #4058#4108
Merged
Merged
Conversation
| - (UIView *)render:(UIView<ACRIContentHoldingView> *)viewGroup | ||
| rootView:(ACRView *)rootView | ||
| inputs:(NSArray *)inputs | ||
| inputs:(NSMutableArray *)inputs |
There was a problem hiding this comment.
Didnt we make a similar change for 1.2.9? Was it someplace else? Was this missed then? Also is this a breaking change to the renderer interface?
Member
Author
There was a problem hiding this comment.
No, this is applied to sample app's custom renderer.
shalinijoshi19
approved these changes
Jun 5, 2020
|
/azp run |
|
No pipelines are associated with this pull request. |
Member
Author
|
/azp run |
|
No pipelines are associated with this pull request. |
Member
Author
|
/azp run |
|
No pipelines are associated with this pull request. |
jwoo-msft
added a commit
that referenced
this pull request
Jul 7, 2020
* Fixed action set cut off issue * updated stretch for vertical distribution Co-authored-by: shalinijoshi19 <[email protected]>
rankush
pushed a commit
to rankush/AdaptiveCards
that referenced
this pull request
May 8, 2024
* Fixed action set cut off issue * updated stretch for vertical distribution Co-authored-by: shalinijoshi19 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
Fixed #4058
Description
ActionsSet's intrinsic content size was not working. When container view that held button were added to UIScrollView, the container view's intrinsic content size didn't work because by the time intrinsic content size was updated to actual value after buttons are rendered, it was too late. Following modifications have been made:
How Verified
cut off issue is fixed as it can be observed below.
previously, buttons were shrunken, now buttons behave correctly even after images are loaded later
existing units tests were run, and verified with all of the cards with different combinations of action alignment host config values.
Microsoft Reviewers: Open in CodeFlow