Added Support for Chevron in UIButton#4222
Merged
Merged
Conversation
|
@jwoo-msft what's our story for Android? What about the other platforms? @golddove / @RebeccaAnne |
| <?xml version="1.0" encoding="UTF-8"?> | ||
| <document type="com.apple.InterfaceBuilder3.CocoaTouch.XIB" version="3.0" toolsVersion="14490.70" targetRuntime="iOS.CocoaTouch" propertyAccessControl="none" useAutolayout="YES" useTraitCollections="YES" useSafeAreas="YES" colorMatched="YES"> | ||
| <device id="retina4_7" orientation="portrait"> | ||
| <adaptation id="fullscreen"/> |
There was a problem hiding this comment.
Curious - how does the xib approach work again? Do they optionally get to pull this in to their source/project or something like that?
Member
Author
There was a problem hiding this comment.
This XIB will be part of iOS SDK. Devs will need to modify this XIB to have "chevrons" for showcard buttons. I've provided such changes in the XIB as part of PR #4221 for reference.
paulcam206
approved these changes
Jun 29, 2020
Member
Author
@shalinijoshi19 UWP should be able to do this through XML. We need to investigate on Android if native styling approaches are feasible. |
…os-actionbutton-update
…daptiveCards into jwoo/ios-actionbutton-update
jwoo-msft
added a commit
that referenced
this pull request
Jul 7, 2020
* Added xib for showcard actions * corrected XIB usage * fixed merge issue * updated separator logic
rankush
pushed a commit
to rankush/AdaptiveCards
that referenced
this pull request
May 8, 2024
* Added xib for showcard actions * corrected XIB usage * fixed merge issue * updated separator logic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
Fixed #4167 for iOS
Description
How Verified
How you verified the fix, including one or all of the following:
Microsoft Reviewers: Open in CodeFlow