Updated Bleed for iOS#4780
Conversation
|
@jwoo-msft this might need to be ported to release/1.2 - let's confirm with the Teams mobile team tonight. Thanks! |
shalinijoshi19
left a comment
There was a problem hiding this comment.
Is this just an iOS issue? @RebeccaAnne should have a peek here too !
I'm not fully grokking the nuance of these changes, but the crash from the bug looks like an iOS specific concern. That said, I ran the bug payload through UWP, .NET, and JavaScript, and it doesn't look like it's rendering quite the same on all platforms. UWP seems to bleed the show card into the show card padding, whereas the other two don't. @jwoo-msft what is this card supposed to look like? UWP (note no emphasis padding around the show card): JavaScript (emphasis border around the show card) (.NET is similar): |
The card above can be condensed to the below. FYI, I added the snippet of this card to our Bleed.Comprehenisve.json. ActionSet ShowCard -> Container with emphasis style with bleed true -> Container with default style. |
* Fixed the crash issue * Fixed Bleeding Crash Issue * finishing up changes for bleed update Co-authored-by: shalinijoshi19 <[email protected]>
* Fixed the crash issue * Fixed Bleeding Crash Issue * finishing up changes for bleed update Co-authored-by: shalinijoshi19 <[email protected]>
* Fixed the crash issue * Fixed Bleeding Crash Issue * finishing up changes for bleed update Co-authored-by: shalinijoshi19 <[email protected]>


Related Issue
Fixed #4745
Description
Setting the constraint with superview for bleed resulted in dependency on the superview. The fix limited the use of constraint to superview. Made explicit reference to the superview for code maintenance.
How Verified
Microsoft Reviewers: Open in CodeFlow