Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Revert "[.NET] Unpin Newtonsoft.JSON version"#5996

Closed
jwoo-msft wants to merge 1 commit into
mainfrom
revert-5959-paulcam/dotnet-newtonsoft-deps
Closed

Revert "[.NET] Unpin Newtonsoft.JSON version"#5996
jwoo-msft wants to merge 1 commit into
mainfrom
revert-5959-paulcam/dotnet-newtonsoft-deps

Conversation

@jwoo-msft

@jwoo-msft jwoo-msft commented Jun 11, 2021

Copy link
Copy Markdown
Member

Reverts #5959

Microsoft Reviewers: Open in CodeFlow

@jwoo-msft jwoo-msft closed this Jun 11, 2021
@jwoo-msft jwoo-msft deleted the revert-5959-paulcam/dotnet-newtonsoft-deps branch June 11, 2021 01:26
@AlexandreArpin

AlexandreArpin commented Jun 14, 2021

Copy link
Copy Markdown

Hi,

Would it be possible to give a short description why this change was reverted?

I believe it would be important to re-open #5575 and/or #5671.

This versioning strategy for Newtonsoft along with the very long release schedule is preventing us from moving forward with a lot of other 3rd party libraries.

Edit: the fix was never reverted, I was mistaken, see my other comment down below

@ig-jb

ig-jb commented Jun 15, 2021

Copy link
Copy Markdown

@jwoo-msft I've no issues if this is temporary but agreed with @AlexandreArpin ; this revert will also block me from upgrading other packages in other projects too -- would be great to hear what the plan is.

@AlexandreArpin

Copy link
Copy Markdown

This PR to revert was opened, but it was never merged.

I am sorry for the confusion my comment caused.

As far as I know, the next version of AdaptiveCards will have unpinned versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants