Remove unnecessary aria-required property from container element#8746
Merged
Conversation
anna-dingler
reviewed
Nov 8, 2023
anna-dingler
approved these changes
Nov 8, 2023
jwoo-msft
pushed a commit
that referenced
this pull request
May 1, 2024
jwoo-msft
added a commit
that referenced
this pull request
May 1, 2024
* Fix `--blue` to be a _smidge_ darker (better contrast on `--black`) (#8745) * Remove unnecessary `aria-required` property from container element (#8746) * Add `hljs-comment` color to fix contrast (#8747) * Switch from textblock to label in Input.Time sample (#8751) * Add missing img alt text in a few spots (#8750) * Slight tweak to common blue background/border color for contrast (#8748) * Add missing `title` to `iframe` in blog post (#8754) * [Samples] Update version for samples using `tooltip` (#8753) * [Designer] Fix treeview control accessibility (#8757) * fixed a11y issue (#8760) * Update README.md (#8802) * Added AdaptiveCards Template WinRT Component (#8805) * added a new project file * added test app and c# winrt component * mostly working? * fix impl * updated nuget path * added c# runtime component * updated * updated * updated * updated * updated * updated * updated * updated * update * removed winrt prject from AC and added C++ console sample app and the AC project to visualizer * removed nuget config changes --------- Co-authored-by: Paul Campbell <[email protected]> * Jwoo/template winrt strong name (#8807) * added a new project file * added test app and c# winrt component * mostly working? * fix impl * updated nuget path * added c# runtime component * updated * updated * updated * updated * updated * updated * updated * updated * update * removed winrt prject from AC and added C++ console sample app and the AC project to visualizer * removed nuget config changes * added strong name * added new property --------- Co-authored-by: Paul Campbell <[email protected]> * Added Package Info (#8811) * added missing package info * for sharing * updated * Update README.md (#8813) * Add headingLevel to host config (#8814) * Update action icon role to presentation (#8815) * Update README.md (#8817) Update release schedule for website * Fix invalid color value (#8819) * [NodeJS] Update hashing algorithm for webpack (#8835) * Update hashing algorithm for webpack Needed to unblock Node >16 * Tabs -> spaces * [NodeJS] Add `ImageSet` class to enable styling (#8838) * [NodeJS] Add optional overflow menu icon rendering (#8847) * Remove tab index from nested inputs (#8848) * [NodeJS] Add `grid` `ImageSet` style (#8845) * Host old content from messagecardplayground on ac.io (#8866) * Fix issue #8520 (#8870) Updated AdaptiveTableCell to override the Type property Co-authored-by: huberemanuel <[email protected]> * Update README.md (#8873) Update icon for unsupported features * Update README.md (#8859) * Add tooltip for Arabic (#8890) * [Website][A11y] Update keyboard nav for blog posts (#8891) * Update keyboard nav for blog posts * Add up/down navigation * Navigate on enter * Designer surface a11y updates (#8888) * Designer surface a11y updates * Update source/nodejs/adaptivecards-designer/src/peer-command.ts Co-authored-by: Paul Campbell <[email protected]> --------- Co-authored-by: Paul Campbell <[email protected]> --------- Co-authored-by: Paul Campbell <[email protected]> Co-authored-by: anna-dingler <[email protected]> Co-authored-by: Matej Simek <[email protected]> Co-authored-by: huberemanuel <[email protected]>
jwoo-msft
added a commit
that referenced
this pull request
May 1, 2024
* Fix `--blue` to be a _smidge_ darker (better contrast on `--black`) (#8745) * Remove unnecessary `aria-required` property from container element (#8746) * Add `hljs-comment` color to fix contrast (#8747) * Switch from textblock to label in Input.Time sample (#8751) * Add missing img alt text in a few spots (#8750) * Slight tweak to common blue background/border color for contrast (#8748) * Add missing `title` to `iframe` in blog post (#8754) * [Samples] Update version for samples using `tooltip` (#8753) * [Designer] Fix treeview control accessibility (#8757) * fixed a11y issue (#8760) * Update README.md (#8802) * Added AdaptiveCards Template WinRT Component (#8805) * added a new project file * added test app and c# winrt component * mostly working? * fix impl * updated nuget path * added c# runtime component * updated * updated * updated * updated * updated * updated * updated * updated * update * removed winrt prject from AC and added C++ console sample app and the AC project to visualizer * removed nuget config changes --------- Co-authored-by: Paul Campbell <[email protected]> * Jwoo/template winrt strong name (#8807) * added a new project file * added test app and c# winrt component * mostly working? * fix impl * updated nuget path * added c# runtime component * updated * updated * updated * updated * updated * updated * updated * updated * update * removed winrt prject from AC and added C++ console sample app and the AC project to visualizer * removed nuget config changes * added strong name * added new property --------- Co-authored-by: Paul Campbell <[email protected]> * Added Package Info (#8811) * added missing package info * for sharing * updated * Update README.md (#8813) * Add headingLevel to host config (#8814) * Update action icon role to presentation (#8815) * Update README.md (#8817) Update release schedule for website * Fix invalid color value (#8819) * [NodeJS] Update hashing algorithm for webpack (#8835) * Update hashing algorithm for webpack Needed to unblock Node >16 * Tabs -> spaces * [NodeJS] Add `ImageSet` class to enable styling (#8838) * [NodeJS] Add optional overflow menu icon rendering (#8847) * Remove tab index from nested inputs (#8848) * [NodeJS] Add `grid` `ImageSet` style (#8845) * Host old content from messagecardplayground on ac.io (#8866) * Fix issue #8520 (#8870) Updated AdaptiveTableCell to override the Type property Co-authored-by: huberemanuel <[email protected]> * Update README.md (#8873) Update icon for unsupported features * Update README.md (#8859) * Add tooltip for Arabic (#8890) * [Website][A11y] Update keyboard nav for blog posts (#8891) * Update keyboard nav for blog posts * Add up/down navigation * Navigate on enter * Designer surface a11y updates (#8888) * Designer surface a11y updates * Update source/nodejs/adaptivecards-designer/src/peer-command.ts Co-authored-by: Paul Campbell <[email protected]> --------- Co-authored-by: Paul Campbell <[email protected]> * updated version --------- Co-authored-by: Paul Campbell <[email protected]> Co-authored-by: anna-dingler <[email protected]> Co-authored-by: Matej Simek <[email protected]> Co-authored-by: huberemanuel <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The
aria-requiredattribute is only valid on elements (or elements with a role matching an element) that have arequiredHTML property. To specifyaria-requiredon other elements violates WCAG rules.How Verified
Local build/test and Accessibility Insights verification