Remove innerHTML usage from dynamic typeahead#8900
Merged
Conversation
beervoley
approved these changes
May 3, 2024
jwoo-msft
approved these changes
May 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
Fixes #8902
Description
Remove innerHTML usage from dynamic typeahead feature. Now we construct the bold text with individual spans + styling.
Sample Card
{ "type": "AdaptiveCard", "version": "1.6", "body": [ { "type": "Input.ChoiceSet", "id": "dynamicChoiceSet", "label": "Enter the name of your team", "placeholder": "AdaptiveCards", "isRequired": true, "errorMessage": "You must select a valid team", "choices": [ { "title": "Office", "value": "1" }, { "title": "Teams", "value": "2" }, { "title": "Outlook", "value": "3" } ], "choices.data": { "type": "Data.Query", "dataset": "teamScopeInOrg", "count": 15, "skip": 0 } } ] }How Verified
Verified manually on the AC site.
Example HTML:
Behavior remains the same: https://github.com/microsoft/AdaptiveCards/assets/98650930/23c9ecff-5507-4146-a064-db98b3932e62