Move root container style override so that Margin override is possible#8913
Merged
Conversation
…ner" so that custom margins can be applied
almedina-ms
reviewed
May 15, 2024
…BuildXamlTreeFromAdaptiveCard into CreateRootCardElement where it can test for style use and skip setting the margin from the host context.
paulcam206
approved these changes
May 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a style override to the root container named "Adaptive.RootContainer" so that custom margins can be applied
Description
This style enables a host to set the margins of the container to be other than uniform. This enables the background of the panel to bleed up into the frame for a card that may be contained in UI that provides a title bar.
How Verified
Manually verified in a host that sets an OverrideStyles that contains a style with this name in its dictionary.