Update project structure, switch to use setup.py #214
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremydvoss
reviewed
Jan 3, 2023
jeremydvoss
reviewed
Jan 3, 2023
jeremydvoss
reviewed
Jan 3, 2023
jeremydvoss
reviewed
Jan 3, 2023
| }, | ||
| python_requires=">=3.7", | ||
| install_requires=[ | ||
| "azure-monitor-opentelemetry-exporter>=1.0.0b10", |
Member
There was a problem hiding this comment.
If we're going to eliminate b8 and b9, maybe we should skip all the way to <=b11 to avoid the issue with logging moduel paths.
Contributor
Author
There was a problem hiding this comment.
Incrementing the version can probably be done in a later pr. I don't want the change to be lost in these commits without context.
Member
There was a problem hiding this comment.
Was incrementing it from b8 to b10 intentional, then?
jeremydvoss
reviewed
Jan 3, 2023
jeremydvoss
approved these changes
Jan 4, 2023
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change project directory structure to look more like what we use for azure-monitor-opentelemetry-exporter
Also adds custom config options to lint so they do not conflict with each other.