microsoft · lzchen · Feb 14, 2023 · Feb 13, 2023 · Feb 13, 2023 · Feb 13, 2023
@@ -40,6 +40,8 @@
     ([#242](https://github.com/microsoft/ApplicationInsights-Python/pull/242))
 - Update to azure-monitor-opentelemetry-exporter 1.0.0b12
     ([#243](https://github.com/microsoft/ApplicationInsights-Python/pull/243))
+- Move symbols to protected, add docstring for api, pin opentelemtry-api/sdk versions
+    ([#244](https://github.com/microsoft/ApplicationInsights-Python/pull/244))
 
 ## [1.0.0b8](https://github.com/microsoft/ApplicationInsights-Python/releases/tag/v1.0.0b8) - 2022-09-26
 

@@ -46,13 +46,13 @@ You can use `configure_azure_monitor` to set up instrumentation for your app to
 * service_name - Specifies the [service][service_semantic_convention_doc] name.
 * service_namespace - Specifies the [service][service_semantic_convention_doc] namespace.
 * service_instance_id - Specifies the [service][service_semantic_convention_doc] instance id.
-* disable_logging - If set to `True`, disables collection and export of logging telemetry.
-* disable_metrics - If set to `True`, disables collection and export of metric telemetry.
-* disable_tracing - If set to `True`, disables collection and export of distributed tracing telemetry.
-* logging_level - Specifies the [logging level][logging_level] of the Opentelemetry Logging Handler. Defaults to logging.NOTSET.
-* logger_name = Specifies the [logger name][logger_name_hierarchy_doc] under which all logging will be instrumented. Defaults to "" which corresponds to the root logger.
+* disable_logging - If set to `True`, disables collection and export of logging telemetry. Defaults to `False`.
+* disable_metrics - If set to `True`, disables collection and export of metric telemetry. Defaults to `False`.
+* disable_tracing - If set to `True`, disables collection and export of distributed tracing telemetry. Defaults to `False`.
+* logging_level - Specifies the [logging level][logging_level] of the logs you would like to collect for your logging pipeline. Defaults to logging.NOTSET.
+* logger_name = Specifies the [logger name][logger_name_hierarchy_doc] under which logging will be instrumented. Defaults to "" which corresponds to the root logger.
 * logging_export_interval_millis - Specifies the logging export interval in milliseconds. Defaults to 5000.
-* metric_readers - Specifies the [metric readers][ot_metric_reader] that you would like to use for your metrics pipeline. Accepts a list of [metric readers][ot_sdk_python_metric_reader].
+* metric_readers - Specifies the [metric readers][ot_metric_reader] that you would like to use for your metric pipeline. Accepts a list of [metric readers][ot_sdk_python_metric_reader].
 * views - Specifies the list of [views][opentelemetry_specification_view] to configure for the metric pipeline. See [here][ot_sdk_python_view_examples] for example usage.
 * sampling_ratio - Specifies the ratio of distributed tracing telemetry to be [sampled][application_insights_sampling]. Accepted values are in the range [0,1]. Defaults to 1.0, meaning no telemetry is sampled out.
 * tracing_export_interval_millis - Specifies the distributed tracing export interval in milliseconds. Defaults to 5000.

@@ -5,9 +5,10 @@
 # --------------------------------------------------------------------------
 import importlib
 from logging import NOTSET, getLogger
-from typing import Any, Dict
+from typing import Dict
 
-from azure.monitor.opentelemetry.distro.util import get_configurations
+from azure.monitor.opentelemetry.distro._types import ConfigurationValue
+from azure.monitor.opentelemetry.distro.util import _get_configurations
 from azure.monitor.opentelemetry.exporter import (
     ApplicationInsightsSampler,
     AzureMonitorLogExporter,
@@ -38,14 +39,33 @@
 )
 
 
-def configure_azure_monitor(**kwargs):
+def configure_azure_monitor(**kwargs) -> None:
     """
     This function works as a configuration layer that allows the
     end user to configure OpenTelemetry and Azure monitor components. The
     configuration can be done via arguments passed to this function.
+    :keyword str connection_string: Connection string for your Application Insights resource.
+    :keyword Sequence[str] connection_string: Specifies the libraries with instrumentations to be enabled.
+    :keyword str service_name: Specifies the service name.
+    :keyword str service_namespace: Specifies the service namespace.
+    :keyword str service_instance_id: Specifies the service instance id.
+    :keyword bool disable_logging: If set to `True`, disables collection and export of logging telemetry. Defaults to `False`.
+    :keyword bool disable_metrics: If set to `True`, disables collection and export of metric telemetry. Defaults to `False`.
+    :keyword bool disable_tracing: If set to `True`, disables collection and export of distributed tracing telemetry. Defaults to `False`.
+    :keyword int logging_level: Specifies the logging of the logs you would like to collect for your logging pipeline.
+    :keyword str logger_name: Specifies the logger name under which logging will be instrumented. Defaults to "" which corresponds to the root logger.
+    :keyword int logging_export_interval_millis: Specifies the logging export interval in milliseconds. Defaults to 5000.
+    :keyword Sequence[MetricReader] metric_readers: Specifies the metric readers that you would like to use for your metric pipeline.
+    :keyword Sequence[View] views: Specifies the list of views to configure for the metric pipeline.
+    :keyword float sampling_ratio: Specifies the ratio of distributed tracing telemetry to be sampled. Accepted values are in the range [0,1]. Defaults to 1.0, meaning no telemetry is sampled out.
+    :keyword int tracing_export_interval_millis: Specifies the distributed tracing export interval in milliseconds. Defaults to 5000.
+    :keyword Dict[str, Any] <instrumentation>_config: Specifies a dictionary of kwargs that will be applied to configuration for instrumentation <instrumentation>.
+    :keyword bool disable_offline_storage: Boolean value to determine whether to disable storing failed telemetry records for retry. Defaults to `False`.
+    :keyword str storage_directory: Storage directory in which to store retry files. Defaults to `<tempfile.gettempdir()>/Microsoft/AzureMonitor/opentelemetry-python-<your-instrumentation-key>`.
+    :rtype: None
     """
 
-    configurations = get_configurations(**kwargs)
+    configurations = _get_configurations(**kwargs)
 
     disable_tracing = configurations.get("disable_tracing", False)
     disable_logging = configurations.get("disable_logging", False)
@@ -73,7 +93,7 @@ def configure_azure_monitor(**kwargs):
     _setup_instrumentations(configurations)
 
 
-def _get_resource(configurations: Dict[str, Any]) -> Resource:
+def _get_resource(configurations: Dict[str, ConfigurationValue]) -> Resource:
     service_name = configurations.get("service_name", "")
     service_namespace = configurations.get("service_namespace", "")
     service_instance_id = configurations.get("service_instance_id", "")
@@ -86,7 +106,9 @@ def _get_resource(configurations: Dict[str, Any]) -> Resource:
     )
 
 
-def _setup_tracing(resource: Resource, configurations: Dict[str, Any]):
+def _setup_tracing(
+    resource: Resource, configurations: Dict[str, ConfigurationValue]
+):
     sampling_ratio = configurations.get("sampling_ratio", 1.0)
     tracing_export_interval_millis = configurations.get(
         "tracing_export_interval_millis", 5000
@@ -104,7 +126,9 @@ def _setup_tracing(resource: Resource, configurations: Dict[str, Any]):
     get_tracer_provider().add_span_processor(span_processor)
 
 
-def _setup_logging(resource: Resource, configurations: Dict[str, Any]):
+def _setup_logging(
+    resource: Resource, configurations: Dict[str, ConfigurationValue]
+):
     logger_name = configurations.get("logger_name", "")
     logging_level = configurations.get("logging_level", NOTSET)
     logging_export_interval_millis = configurations.get(
@@ -124,7 +148,9 @@ def _setup_logging(resource: Resource, configurations: Dict[str, Any]):
     getLogger(logger_name).addHandler(handler)
 
 
-def _setup_metrics(resource: Resource, configurations: Dict[str, Any]):
+def _setup_metrics(
+    resource: Resource, configurations: Dict[str, ConfigurationValue]
+):
     views = configurations.get("views", ())
     metric_readers = configurations.get("metric_readers", [])
     metric_exporter = AzureMonitorMetricExporter(**configurations)
@@ -137,7 +163,7 @@ def _setup_metrics(resource: Resource, configurations: Dict[str, Any]):
     set_meter_provider(meter_provider)
 
 
-def _setup_instrumentations(configurations: Dict[str, Any]):
+def _setup_instrumentations(configurations: Dict[str, ConfigurationValue]):
     instrumentations = configurations.get("instrumentations", [])
     instrumentation_configs = {}
 

@@ -0,0 +1,23 @@
+# -------------------------------------------------------------------------
+# Copyright (c) Microsoft Corporation. All rights reserved.
+# Licensed under the MIT License. See License in the project root for
+# license information.
+# --------------------------------------------------------------------------
+
+from typing import Sequence, Union
+
+from opentelemetry.sdk.metrics.export import MetricReader
+from opentelemetry.sdk.metrics.view import View
+
+ConfigurationValue = Union[
+    str,
+    bool,
+    int,
+    float,
+    Sequence[str],
+    Sequence[bool],
+    Sequence[int],
+    Sequence[float],
+    Sequence[MetricReader],
+    Sequence[View],
+]
@@ -4,10 +4,12 @@
 # license information.
 # --------------------------------------------------------------------------
 
-from typing import Any, Dict
+from typing import Dict
 
+from azure.monitor.opentelemetry.distro._types import ConfigurationValue
 
-def get_configurations(**kwargs) -> Dict[str, Any]:
+
+def _get_configurations(**kwargs) -> Dict[str, ConfigurationValue]:
     configurations = {}
 
     for key, val in kwargs.items():

@@ -91,13 +91,15 @@
         "opentelemetry-instrumentation-requests~=0.36b0",
         "opentelemetry-instrumentation-flask~=0.36b0",
         "opentelemetry-instrumentation-psycopg2~=0.36b0",
+        "opentelemetry-api==1.15.0",
+        "opentelemetry-sdk==1.15.0",
     ],
     entry_points={
         "opentelemetry_distro": [
-            "azure_monitor_opentelemetry_distro = azure.monitor.opentelemetry.distro.distro:AzureMonitorDistro"
+            "azure_monitor_opentelemetry_distro = azure.monitor.opentelemetry.distro._distro:AzureMonitorDistro"
         ],
         "opentelemetry_configurator": [
-            "azure_monitor_opentelemetry_configurator = azure.monitor.opentelemetry.distro.configurator:AzureMonitorConfigurator"
+            "azure_monitor_opentelemetry_configurator = azure.monitor.opentelemetry.distro._configurator:AzureMonitorConfigurator"
         ],
     },
 )
@@ -14,12 +14,12 @@
 
 import unittest
 
-from azure.monitor.opentelemetry.distro.util import get_configurations
+from azure.monitor.opentelemetry.distro.util import _get_configurations
 
 
 class TestUtil(unittest.TestCase):
     def test_get_configurations(self):
-        configurations = get_configurations(
+        configurations = _get_configurations(
             connection_string="test_cs",
             disable_logging="test_disable_logging",
             disable_tracing="test_disable_tracing",

@@ -0,0 +1,20 @@
+# -------------------------------------------------------------------------
+# Copyright (c) Microsoft Corporation. All rights reserved.
+# Licensed under the MIT License. See License in the project root for
+# license information.
+# --------------------------------------------------------------------------
+
+import unittest
+
+from opentelemetry.instrumentation.django import DjangoInstrumentor
+
+
+class TestDjangoInstrumentation(unittest.TestCase):
+    def test_instrument(self):
+        try:
+            DjangoInstrumentor().instrument()
+        except Exception as ex:  # pylint: disable=broad-except
+            print(ex)
+            self.fail(
+                f"Unexpected exception raised when instrumenting {DjangoInstrumentor.__name__}"
+            )
@@ -1,12 +1,12 @@
 from unittest import TestCase
 from unittest.mock import patch
 
-from azure.monitor.opentelemetry.distro.distro import AzureMonitorDistro
+from azure.monitor.opentelemetry.distro._distro import AzureMonitorDistro
 
 
 class TestDistro(TestCase):
     @patch(
-        "azure.monitor.opentelemetry.distro.distro.AzureDiagnosticLogging.enable"
+        "azure.monitor.opentelemetry.distro._distro.AzureDiagnosticLogging.enable"
     )
     # TODO: Enabled when duplciate logging issue is solved
     # @patch(
@@ -18,9 +18,9 @@ def test_configure(self, mock_diagnostics):
         distro.configure()
         self.assertEqual(mock_diagnostics.call_count, 2)
 
-    # TODO: Enabled when duplciate logging issue is solved
+    # TODO: Enabled when duplicate logging issue is solved
     # @patch(
-    #     "azure.monitor.opentelemetry.distro.distro.AzureDiagnosticLogging.enable"
+    #     "azure.monitor.opentelemetry.distro._distro.AzureDiagnosticLogging.enable"
     # )
     # @patch(
     #     "azure.monitor.opentelemetry.distro._diagnostic_logging._EXPORTER_DIAGNOSTICS_ENABLED",