Enable azure core tracing #269
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
babc159 to
4d0ab08
Compare
2df1c97 to
d7086a4
Compare
8c0aaf1 to
6b9486f
Compare
lzchen
reviewed
Jun 27, 2023
| | Parameter | Description | Environment Variable | | ||
| |-------------------|----------------------------------------------------|----------------------| | ||
| | `connection_string` | The [connection string][connection_string_doc] for your Application Insights resource. The connection string will be automatically populated from the `APPLICATIONINSIGHTS_CONNECTION_STRING` environment variable if not explicitly passed in. | `APPLICATIONINSIGHTS_CONNECTION_STRING` | | ||
| <!-- Placeholder for azure core tracing configuration | `disable_azure_core_tracing` | If set to `True`, disables the [Azure Core Tracing OpenTelemetry Plugin][azure_core_tracing_opentelemetry_plugin]. This feature instruments Azure Core functionality to produce OpenTelemetry distributed tracing telemetry. See [samples][azure_core_tracing_opentelemetry_plugin_samples] for more | | --> |
Contributor
There was a problem hiding this comment.
What is this placeholder for?
Member
Author
There was a problem hiding this comment.
In case they push a bug, I think we should eventually have a way to disable the feature since we are not in charge of the plug in.
Contributor
There was a problem hiding this comment.
Why not just include the config and not have a placeholder?
lzchen
reviewed
Jun 27, 2023
lzchen
reviewed
Jun 27, 2023
lzchen
reviewed
Jun 29, 2023
| AzureStatusLogger.log_status(False, "Distro being configured.") | ||
| AzureDiagnosticLogging.enable(_logger) | ||
| AzureDiagnosticLogging.enable(_opentelemetry_logger) | ||
| # TODO: Enabled when duplicate logging issue is solved |
Contributor
There was a problem hiding this comment.
IS this TODO no longer needed?
Member
Author
There was a problem hiding this comment.
Yeah. Turns out diagnostic logging for attach is supposed to work differently. Has to do with AppLens.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding Azure-Core Tracing Extension:
https://github.com/Azure/azure-sdk-for-python/tree/main/sdk/core/azure-core-tracing-opentelemetry