Remove most code configuration #277
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0f25e0b to
fe17ac8
Compare
fe17ac8 to
c09dd05
Compare
a0d43c3 to
1a85a17
Compare
90a5b99 to
80472be
Compare
jeremydvoss
commented
May 2, 2023
| dep_mock.assert_called_with(ep2_mock.dist) | ||
| ep_mock.load.assert_not_called() | ||
| ep2_mock.load.assert_called_once() | ||
| instrumentor_mock.instrument.assert_called_once() |
Member
Author
There was a problem hiding this comment.
This diff turned out weird, but if you expand below, you'll see that I mainly just removed test_setup_instrumentations_lib_excluded, test_setup_instrumentations_custom_configuration, and test_setup_instrumentations_custom_configuration_excluded
lzchen
reviewed
May 4, 2023
lzchen
reviewed
May 4, 2023
lzchen
reviewed
May 4, 2023
| | `OTEL_METRICS_EXPORTER` | If set to `None`, disables collection and export of metric telemetry. | | ||
| | `OTEL_LOGS_EXPORTER` | If set to `None`, disables collection and export of distributed tracing telemetry. | | ||
| | `OTEL_BLRP_SCHEDULE_DELAY` | Specifies the logging export interval in milliseconds. Defaults to 5000. | | ||
| | `OTEL_TRACES_SAMPLER_ARG` | Specifies the ratio of distributed tracing telemetry to be [sampled][application_insights_sampling]. Accepted values are in the range [0,1]. Defaults to 1.0, meaning no telemetry is sampled out. | |
Contributor
There was a problem hiding this comment.
Nit: Switch the ordering of the last two so OTEL_x_SCHEDULE_DELAY variables are grouped together.
lzchen
reviewed
May 4, 2023
| logger_name = configurations[LOGGER_NAME_ARG] | ||
| logging_level = configurations[LOGGING_LEVEL_ARG] | ||
| def _setup_logging(configurations: Dict[str, ConfigurationValue]): | ||
| # TODO: Remove after upgrading to 1.18 |
Contributor
There was a problem hiding this comment.
Does this mean upgrading to opentelemetry-sdk 1.18 because it's in the latest release?
lzchen
reviewed
May 4, 2023
| def configure_azure_monitor(**kwargs) -> None: | ||
| """ | ||
| This function works as a configuration layer that allows the | ||
| end user to configure OpenTelemetry and Azure monitor components. The |
Contributor
There was a problem hiding this comment.
Do we still need InstrumentationConfig type above?
Member
Author
There was a problem hiding this comment.
Good point. Will remove.
Contributor
|
LGTM except a few comments. |
lzchen
approved these changes
May 4, 2023
Co-authored-by: Leighton Chen <[email protected]>
Co-authored-by: Leighton Chen <[email protected]>
e2abb45 to
97fb414
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing the following parameters for configure_azure_monitor:
Configuration for some of these items will still be possible through env vars.