Thanks to visit codestin.com
Credit goes to github.com

Skip to content

spelling #291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jeremydvoss merged 4 commits into from
Jun 9, 2023
Merged

spelling #291

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1f8851e
spelling
jeremydvoss Jun 8, 2023
7e7a97b
spelling
jeremydvoss Jun 8, 2023
b4e8cb9
Merge branch 'spellcheck' of https://github.com/jeremydvoss/Applicati…
jeremydvoss Jun 8, 2023
1d8d9f5
spelling
jeremydvoss Jun 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@

- Update samples
([#281](https://github.com/microsoft/ApplicationInsights-Python/pull/281))
- Fixed spelling
([#291](https://github.com/microsoft/ApplicationInsights-Python/pull/291))

## [1.0.0b12](https://github.com/microsoft/ApplicationInsights-Python/releases/tag/v1.0.0b12) - 2023-05-05

Expand Down Expand Up @@ -74,11 +76,11 @@
([#242](https://github.com/microsoft/ApplicationInsights-Python/pull/242))
- Update to azure-monitor-opentelemetry-exporter 1.0.0b12
([#243](https://github.com/microsoft/ApplicationInsights-Python/pull/243))
- Move symbols to protected, add docstring for api, pin opentelemtry-api/sdk versions
- Move symbols to protected, add docstring for api, pin opentelemetry-api/sdk versions
([#244](https://github.com/microsoft/ApplicationInsights-Python/pull/244))
- Replace service.X configurations with Resource
([#246](https://github.com/microsoft/ApplicationInsights-Python/pull/246))
- Change namespace to `azure.monitor.opentelemtry`
- Change namespace to `azure.monitor.opentelemetry`
([#247](https://github.com/microsoft/ApplicationInsights-Python/pull/247))
- Updating documents for new namespace
([#249](https://github.com/microsoft/ApplicationInsights-Python/pull/249))
Expand Down
2 changes: 1 addition & 1 deletion azure-monitor-opentelemetry/azure/monitor/opentelemetry/_configure.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,7 @@ def _setup_instrumentations():
instrumentor().instrument(skip_dep_check=True)
except Exception as ex:
_logger.warning(
"Exception occured when instrumenting: %s.",
"Exception occurred when instrumenting: %s.",
lib_name,
exc_info=ex,
)
6 changes: 3 additions & 3 deletions azure-monitor-opentelemetry/azure/monitor/opentelemetry/_constants.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
_IS_ON_APP_SERVICE = "WEBSITE_SITE_NAME" in environ
# TODO: Add environment variable to enabled diagnostics off of App Service
_IS_DIAGNOSTICS_ENABLED = _IS_ON_APP_SERVICE
# TODO: Enabled when duplciate logging issue is solved
# TODO: Enabled when duplicate logging issue is solved
# _EXPORTER_DIAGNOSTICS_ENABLED_ENV_VAR = (
# "AZURE_MONITOR_OPENTELEMETRY_DISTRO_ENABLE_EXPORTER_DIAGNOSTICS"
# )
Expand Down Expand Up @@ -63,7 +63,7 @@ def _env_var_or_default(var_name, default_val=""):
return default_val


# TODO: Enabled when duplciate logging issue is solved
# TODO: Enabled when duplicate logging issue is solved
# def _is_exporter_diagnostics_enabled():
# return (
# _EXPORTER_DIAGNOSTICS_ENABLED_ENV_VAR in environ
Expand All @@ -74,5 +74,5 @@ def _env_var_or_default(var_name, default_val=""):
_EXTENSION_VERSION = _env_var_or_default(
"ApplicationInsightsAgent_EXTENSION_VERSION", "disabled"
)
# TODO: Enabled when duplciate logging issue is solved
# TODO: Enabled when duplicate logging issue is solved
# _EXPORTER_DIAGNOSTICS_ENABLED = _is_exporter_diagnostics_enabled()
2 changes: 1 addition & 1 deletion azure-monitor-opentelemetry/azure/monitor/opentelemetry/autoinstrumentation/_distro.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ def _configure(self, **kwargs) -> None:
_configure_auto_instrumentation()
except Exception as ex:
_logger.exception(
("Error occured auto-instrumenting AzureMonitorDistro")
("Error occurred auto-instrumenting AzureMonitorDistro")
)
raise ex

Expand Down
2 changes: 1 addition & 1 deletion azure-monitor-opentelemetry/samples/tracing/manual.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@

engine = create_engine("sqlite:///:memory:")
# SQLAlchemy instrumentation is not officially supported by this package
# However, you can use the OpenTelemetry instument method manually in
# However, you can use the OpenTelemetry instrument method manually in
# conjunction with configure_azure_monitor
SQLAlchemyInstrumentor().instrument(
engine=engine,
Expand Down
2 changes: 1 addition & 1 deletion azure-monitor-opentelemetry/tests/autoinstrumentation/test_distro.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ class TestDistro(TestCase):
@patch(
"azure.monitor.opentelemetry.autoinstrumentation._distro.AzureDiagnosticLogging.enable"
)
# TODO: Enabled when duplciate logging issue is solved
# TODO: Enabled when duplicate logging issue is solved
# @patch(
# "azure.monitor.opentelemetry.autoinstrumentation._diagnostic_logging._EXPORTER_DIAGNOSTICS_ENABLED",
# False,
Expand Down
2 changes: 1 addition & 1 deletion azure-monitor-opentelemetry/tests/test_constants.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ def test_ikey_defaults(self):
reload(_constants)
self.assertEqual(_constants._CUSTOMER_IKEY, "unknown")

# TODO: Enabled when duplciate logging issue is solved
# TODO: Enabled when duplicate logging issue is solved
# @patch.dict(
# "os.environ",
# {"AZURE_MONITOR_OPENTELEMETRY_DISTRO_ENABLE_EXPORTER_DIAGNOSTICS": "True"},
Expand Down