Thanks to visit codestin.com
Credit goes to github.com

Skip to content

SDK connection string#1187

Merged
TimothyMothra merged 69 commits into
developfrom
tilee/connectionString
Sep 24, 2019
Merged

SDK connection string#1187
TimothyMothra merged 69 commits into
developfrom
tilee/connectionString

Conversation

@TimothyMothra

@TimothyMothra TimothyMothra commented Aug 2, 2019 •
edited
Loading

Copy link
Copy Markdown

#1221

Ruleset

  1. check for explicit endpoint (location is ignored)
  2. check for endpoint suffix (location is optional)
  3. use classic endpoint (location is ignored)

Design

  • New property: TelemetryConfiguration.ConnectionString
  • New method: TelemetryConfiguration.SetConnectionString())
    Connection string needs to be parsed (via EndpointProvider) and validated.
    This method will set TelemetryConfiguration.InstrumentationKey.
    Resulting endpoints are set to TelemetryConfiguration.Endpoints (EndpointContainer).
    This method will also update TelemetryChannel.Endpoint
  • Contains about 220 new Tests.

@TimothyMothra TimothyMothra added this to the 2.12 milestone Aug 2, 2019
pharring
pharring reviewed Aug 2, 2019
View reviewed changes
Comment thread src/Microsoft.ApplicationInsights/Extensibility/Implementation/Endpoints/Constants.cs Outdated
@pharring

pharring commented Aug 2, 2019

Copy link
Copy Markdown
Contributor

@jemodyMS @clguimanMSFT FYI

Dmitry-Matveev
Dmitry-Matveev approved these changes Sep 19, 2019
View reviewed changes
Comment thread Test/Microsoft.ApplicationInsights.Test/Shared/Extensibility/TelemetryConfigurationTest.cs
Comment thread Test/Microsoft.ApplicationInsights.Test/Shared/Extensibility/TelemetryConfigurationTest.cs
@TimothyMothra TimothyMothra marked this pull request as ready for review September 23, 2019 23:10
@TimothyMothra

TimothyMothra commented Sep 23, 2019

Copy link
Copy Markdown
Author

@lmolkova Can you please re-review? You're currently blocking this PR. :)

@TimothyMothra TimothyMothra changed the title [WIP] SDK connection string SDK connection string Sep 23, 2019
@TimothyMothra TimothyMothra merged commit ed4cc44 into develop Sep 24, 2019
cijothomas
cijothomas reviewed Sep 24, 2019
View reviewed changes
Comment thread CHANGELOG.md
Comment thread src/Microsoft.ApplicationInsights/Extensibility/Implementation/TelemetryConfigurationFactory.cs
Comment thread src/Microsoft.ApplicationInsights/Extensibility/Implementation/TelemetryConfigurationFactory.cs
Comment thread src/Microsoft.ApplicationInsights/Extensibility/Implementation/Tracing/CoreEventSource.cs
Comment thread src/Microsoft.ApplicationInsights/Extensibility/TelemetryConfiguration.cs
Comment thread src/Microsoft.ApplicationInsights/Extensibility/TelemetryConfiguration.cs
Comment thread src/Microsoft.ApplicationInsights/Extensibility/Implementation/Endpoints/EndpointContainer.cs
Comment thread src/ServerTelemetryChannel/ServerTelemetryChannel.cs
Comment thread src/Microsoft.ApplicationInsights/Extensibility/TelemetryConfiguration.cs
Comment thread src/Microsoft.ApplicationInsights/Extensibility/TelemetryConfiguration.cs
@TimothyMothra TimothyMothra mentioned this pull request Oct 24, 2019
Closed
@TimothyMothra TimothyMothra deleted the tilee/connectionString branch November 15, 2019 00:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cijothomas cijothomas cijothomas left review comments
@reyang reyang reyang left review comments
@Dmitry-Matveev Dmitry-Matveev Dmitry-Matveev approved these changes
+3 more reviewers
@pharring pharring pharring left review comments
@lmolkova lmolkova lmolkova approved these changes
@juliusl juliusl juliusl approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

config file

Projects

None yet

Milestone

2.12

Development

Successfully merging this pull request may close these issues.

7 participants

@TimothyMothra @pharring @reyang @lmolkova @cijothomas @juliusl @Dmitry-Matveev