Bug fix in TelemetryConfiguration + ConnectionStrings#1230
Merged
Conversation
added 3 commits
October 1, 2019 16:09
Dmitry-Matveev
approved these changes
Oct 9, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #1221
The Cause
Channels previously held a default endpoint value.
I changed that to read from the TelemetryConfiguration.EndpointContainer.
EndpointContainer now holds the default values unless overwritten by setting a ConnectionString.
In this example, No ConnectionString is in use and the Channel holds a custom Endpoint.
This custom Endpoint is being overwritten by the TelemetryConfiguration.EndpointContainer which is an error.
The fix
I introduced a
forceparameter.If a Channel has had it's endpoint set before adding to the Configuration, it will not be overwritten.
However, anytime the ConnectionString is set, the Channel will always be overwritten.