StandardMetric Pre-Aggregation with all expected dimensions#1278
Merged
Conversation
Dmitry-Matveev
approved these changes
Nov 1, 2019
|
|
||
| public string ExtractDimension(ITelemetry item) | ||
| { | ||
| return MetricTerms.Autocollection.Metric.DependencyCallDuration.Id; |
Member
There was a problem hiding this comment.
minor: return DefaultValue looks to be the same here.
Contributor
Author
There was a problem hiding this comment.
yup. Default is never going to be used as the ExtractDimension always return a constant.
…github.com/microsoft/ApplicationInsights-dotnet into cijothomas/standardmetricaggwithdimensions
…github.com/microsoft/ApplicationInsights-dotnet into cijothomas/standardmetricaggwithdimensions
|
Functional Tests are catching this:
I don't know why the Gated build is not. |
…github.com/microsoft/ApplicationInsights-dotnet into cijothomas/standardmetricaggwithdimensions
Dmitry-Matveev
approved these changes
Nov 15, 2019
| public class DependencyTypeDimesnionExtractorTest | ||
| { | ||
| [TestMethod] | ||
| public void NullTarget() |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addressing #1233
TODO:
Tests
PerformanceBucket dimension
Perf Tests
Will finalize the default dimension limits after more perf/cost research.