You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In W3C mode we report parentId and Id in the format of |traceId.parentSpanId. and |traceId.spanId. respectively.
This is not needed anymore even for backward compatibility reasons. Compatibility with old versions of Application Insights SDK is handled by ingestion.
Describe the solution you would like
When SDK receives a valid incoming request with
traceparent = 00-traceId-parentId-00, it should track request telemetry
request.Context.Operation.Id = traceId // no changes
request.Context.Operation.ParentId = parentId // new, was |traceId.parentId.
request.Id = new span Id // new, was |traceId.spanId.
no header, it should track request telemetry
request.Context.Operation.Id = new traceId // no changes
request.Context.Operation.ParentId = null // no changes
request.Id = new span Id// new, was |traceId.spanId.
legacy Request-Id header, it should track request telemetry
request.Context.Operation.Id = if request-id root part is compatible with trace-id, reuse it, otherwise generate a new one
request.Context.Operation.ParentId = headers[Request-Id] // no changes
request.Id = new span Id // new, was |traceId.spanId.
properties["ai_LegacyRootId"] = if request-id root part is NOT compatible with trace-id, put it here, otherwise keep empty // no changes
Similarly for dependencies
dependency.Context.Operation.Id = traceId,
dependency.Context.Operation.ParentId = parent span id, // new, was |trace.parent.
dependency.Id = new span id, // new, was |trace.span.
When sending Request-Id in outgoing requests it still MUST be formatted in the |TraceId.SpanId. format!
DiagnosticListeners\Implementation\HostingDiagnosticListener.cs(578,94): error CA1801: Parameter operationId of method GetParentId is never used. Remove the parameter or use it in the method body. [E:\A_work\20\s\NETCORE\src\Microsoft.ApplicationInsights.AspNetCore\Microsoft.ApplicationInsights.AspNetCore.csproj]
Sorry. FxCop is an SDL requirement.
If you can review and confirm that this change was intentional, I would be more than happy to fix it for you. :)
You're also getting errors about a missing XML document. This is a new check that I added yesterday. These shouldn't be running against the Test projects and it's not actually failing your build.
It's safe to ignore this error and I'll get this fixed today.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In W3C mode we report parentId and Id in the format of
|traceId.parentSpanId.and|traceId.spanId.respectively.This is not needed anymore even for backward compatibility reasons. Compatibility with old versions of Application Insights SDK is handled by ingestion.
Describe the solution you would like
When SDK receives a valid incoming request with
traceparent = 00-traceId-parentId-00, it should track request telemetrySimilarly for dependencies
When sending Request-Id in outgoing requests it still MUST be formatted in the |TraceId.SpanId. format!