Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Copy tags if we create new Activity in ASP.NET Core listener#1660

Merged
lmolkova merged 3 commits into
developfrom
lmolkova/fixTagsPropagationForCustomActivities
Jan 31, 2020
Merged

Copy tags if we create new Activity in ASP.NET Core listener#1660
lmolkova merged 3 commits into
developfrom
lmolkova/fixTagsPropagationForCustomActivities

Conversation

@lmolkova

Copy link
Copy Markdown

Changes

Some tags could be populated by users or 1P libraries (codex) on the Activity created by ASP.NET Core.

In some cases we drop this activity to substitute it with proper one (e.g. when we know W3C is not supported by the ASP.NET Core based on version). In this case we need to copy tags as well.

Checklist

  • I ran Unit Tests locally.
  • CHANGELOG.md updated with one line description of the fix, and a link to the original issue if available.

Notes for authors:

  • FxCop and other analyzers will fail the build. To see these errors yourself, compile localy using the Release configuration.

Notes for reviewers:

  • We support comment build triggers
    • /AzurePipelines run will queue all builds
    • /AzurePipelines run <pipeline-name> will queue a specific build

@lmolkova lmolkova force-pushed the lmolkova/fixTagsPropagationForCustomActivities branch from 2730ba4 to cf1479e Compare January 31, 2020 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants