Add Support for Cloud Role Name for Quickpulse SDK#2100
Merged
Conversation
tokaplan
requested changes
Oct 27, 2020
tokaplan
approved these changes
Oct 28, 2020
|
LGTM. Please update the Changelog under the section "VNext" |
TimothyMothra
approved these changes
Oct 30, 2020
cijothomas
approved these changes
Oct 30, 2020
cijothomas
left a comment
Contributor
There was a problem hiding this comment.
LGTM.
Wondering what is the actual UI change planned with this feature. Is it to do filtering? or show rolename, along with roleinstance in the charts?
Contributor
Author
Yes. The UX will let you see the roles and filter by them too. This is especially in our use case with AKS clusters where we can restrict roles that we dont want sending data and choking our service |
This was referenced Dec 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix Issue # .
Changes
Added support for Cloud Role Name for Quickpulse SDK
Checklist
For significant contributions please make sure you have completed the following items:
The PR will trigger build, unit tests, and functional tests automatically. Please follow these instructions to build and test locally.
Notes for authors:
Notes for reviewers:
/AzurePipelines runwill queue all builds/AzurePipelines run <pipeline-name>will queue a specific build