Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[PoC] Support for Redfield#2348

Closed
TimothyMothra wants to merge 9 commits into
developfrom
tilee/redfield
Closed

[PoC] Support for Redfield#2348
TimothyMothra wants to merge 9 commits into
developfrom
tilee/redfield

Conversation

@TimothyMothra

@TimothyMothra TimothyMothra commented Jul 30, 2021

Copy link
Copy Markdown

Changes

  • Introduce build flag Redfield=True
  • When detected, change version of dependency: System.Diagnostics.DiagnosticSource
  • When detected set a Constant to be used in preprocessor. This is used to change the name of EventSource.

To use:

dotnet build /p:Redfield=True

To verify:

I introduced a new unit test to verify that these changes took effect.

dotnet build /p:Redfield=True ".\dotnet\BASE\Microsoft.ApplicationInsights.sln"
dotnet test ".\bin\Debug\test\Microsoft.ApplicationInsights.Tests\net5.0\Microsoft.ApplicationInsights.Tests.dll" --filter Name~VerifyRedfieldEventSourceName

Open Questions

  • Do we need to run full tests against Redfield build?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant