Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix Metric livelock by replacing potential infinate loop in MetricValuesBuffer.GetAndResetValue #2612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TimothyMothra merged 10 commits into from
Jun 17, 2022
Merged

fix Metric livelock by replacing potential infinate loop in MetricValuesBuffer.GetAndResetValue #2612

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
74b921c
initial commit
Jun 15, 2022
59a34a2
less invasive change
Jun 16, 2022
891bced
rename
Jun 16, 2022
eac36ef
Merge branch 'main' into tilee/1186_GetAndResetValue
Jun 16, 2022
0817a0b
review comment and changelog
Jun 16, 2022
b9c3166
Update CHANGELOG.md
Jun 16, 2022
ed14949
update changelog
Jun 17, 2022
e062585
log warning
Jun 17, 2022
404ef6c
sort usings
Jun 17, 2022
10f521c
fxcop
Jun 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions ...src/Microsoft.ApplicationInsights/Extensibility/Implementation/Tracing/CoreEventSource.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -672,6 +672,9 @@ public void IngestionResponseTimeEventCounter(float responseDurationInMs)
[Event(75, Message = "Ingestion Service responded with redirect. {0}", Level = EventLevel.Error)]
public void IngestionRedirectError(string message, string appDomainName = "Incorrect") => this.WriteEvent(75, message, this.nameProvider.Name);

[Event(76, Message = "MetricValueBuffer exceeded spin count.", Level = EventLevel.Warning)]
public void MetricValueBufferExceededSpinCount(string appDomainName = "Incorrect") => this.WriteEvent(76, this.nameProvider.Name);

[NonEvent]
public void TransmissionStatusEventFailed(Exception ex)
{
Expand Down
12 changes: 10 additions & 2 deletions BASE/src/Microsoft.ApplicationInsights/Metrics/Extensibility/MetricValuesBuffer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@
using System.Threading;
using System.Threading.Tasks;

using Microsoft.ApplicationInsights.Extensibility.Implementation.Tracing;

#pragma warning disable SA1649 // File name must match first type name
#pragma warning disable SA1402 // File may only contain a single class

Expand Down Expand Up @@ -91,13 +93,19 @@ public TValue GetAndResetValue(int index)
while (this.IsInvalidValue(value))
{
spinWait.SpinOnce();

if (spinWait.Count % 100 == 0)
{
// In tests (including stress tests) we always finished wating before 100 cycles.
// In tests (including stress tests) we always finished waiting before 100 cycles.
// However, this is a protection against en extreme case on a slow machine.
Task.Delay(10).ConfigureAwait(continueOnCapturedContext: false).GetAwaiter().GetResult();
}
else if (spinWait.Count > 10000)
{
// Exceeded maximum spin count. Break out to avoid infinite loop.
CoreEventSource.Log.MetricValueBufferExceededSpinCount();
break;
}

value = this.GetAndResetValueOnce(this.values, index);
}
Expand Down
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,8 @@
- [Extension methods to retrive specific operation details.](https://github.com/microsoft/ApplicationInsights-dotnet/issues/1350)
- [Mark Instrumentation Key based APIs as Obsolete](https://github.com/microsoft/ApplicationInsights-dotnet/issues/2560).
- See also: https://docs.microsoft.com/azure/azure-monitor/app/migrate-from-instrumentation-keys-to-connection-strings
- [Fix: Livelock in MetricValuesBuffer.](https://github.com/microsoft/ApplicationInsights-dotnet/pull/2612)
Comment thread
TimothyMothra marked this conversation as resolved.
Mitigation for TelemetryClient.Flush deadlocks ([#1186](https://github.com/microsoft/ApplicationInsights-dotnet/issues/1186))

## Version 2.21.0-beta1
- [Support IPv6 in request headers](https://github.com/microsoft/ApplicationInsights-dotnet/issues/2521)
Expand Down