Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Support internal and client spans from cosmos db#2712

Merged
TimothyMothra merged 5 commits into
microsoft:mainfrom
lmolkova:cosmos-internal-client-suppress-nested-http
Feb 1, 2023
Merged

Support internal and client spans from cosmos db#2712
TimothyMothra merged 5 commits into
microsoft:mainfrom
lmolkova:cosmos-internal-client-suppress-nested-http

Conversation

@lmolkova

@lmolkova lmolkova commented Nov 14, 2022 •
edited
Loading

Copy link
Copy Markdown

Addressing portal team feedback on new Cosmos instrumentation:

  • in Direct (TCP mode), Cosmos will set Client kind on activities. Even though Cosmos uses TCP, some rare HTTP requests will be made under these activities, so there will be a few occasional client->client spans.
  • In Gateway (HTTP mode), Cosmos will set Internal kind on activities. Users are expected to get both internal (logical) activities and nested HTTP calls.

@lmolkova lmolkova force-pushed the cosmos-internal-client-suppress-nested-http branch from 1a58e53 to 1d4bbd6 Compare November 16, 2022 01:12
@lmolkova lmolkova force-pushed the cosmos-internal-client-suppress-nested-http branch from 1d4bbd6 to 5b62194 Compare January 11, 2023 01:50
sourabh1007
sourabh1007 approved these changes Jan 12, 2023
View reviewed changes

@sourabh1007 sourabh1007 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!!

reyang
reyang approved these changes Jan 13, 2023
View reviewed changes

@reyang reyang left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a changelog entry.

@lmolkova

lmolkova commented Jan 18, 2023

Copy link
Copy Markdown
Author

LGTM with a changelog entry.

thank you @reyang! I updated the changelog.

@TimothyMothra TimothyMothra merged commit 18be714 into microsoft:main Feb 1, 2023
@lmolkova

lmolkova commented Feb 1, 2023

Copy link
Copy Markdown
Author

thank you @TimothyMothra !

@TimothyMothra TimothyMothra mentioned this pull request Jan 23, 2024
Closed
@dependabot dependabot Bot mentioned this pull request Jul 28, 2025
Closed
@dependabot dependabot Bot mentioned this pull request Aug 4, 2025
Open
@dependabot dependabot Bot mentioned this pull request Aug 14, 2025
Open
This was referenced Dec 5, 2025
Open
Merged
This was referenced Dec 12, 2025
Merged
Merged
This was referenced Dec 22, 2025
Merged
Closed
Closed
This was referenced Mar 23, 2026
Closed
Open
This was referenced Apr 7, 2026
Open
Closed
@dependabot dependabot Bot mentioned this pull request Apr 20, 2026
Closed
@dependabot dependabot Bot mentioned this pull request Apr 27, 2026
Closed
This was referenced May 11, 2026
Closed
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced May 18, 2026
Closed
Closed
@dependabot dependabot Bot mentioned this pull request Jun 2, 2026
Closed
This was referenced Jun 15, 2026
Open
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@reyang reyang reyang approved these changes

+1 more reviewer

@sourabh1007 sourabh1007 sourabh1007 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@lmolkova @sourabh1007 @reyang @TimothyMothra