Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix gcc build problem#1149

Merged
carsonRadtke merged 1 commit into
microsoft:mainfrom
beinhaerter:fix-gcc-build
Oct 12, 2024
Merged

Fix gcc build problem#1149
carsonRadtke merged 1 commit into
microsoft:mainfrom
beinhaerter:fix-gcc-build

Conversation

@beinhaerter
Copy link
Copy Markdown
Contributor

Closes issue #1148 by fixing problems introduced in PR #1140.

@beinhaerter
Copy link
Copy Markdown
Contributor Author

This pull request is waiting to be merged since two monthes. Is there something missing or needs to be done?

@d-winsor
Copy link
Copy Markdown
Contributor

@beinhaerter There appears to be problems with the checks running on older PRs. Can you please push an empty commit to retrigger tests.

Closes issue microsoft#1148 by fixing problems introduced in PR microsoft#1140.
@beinhaerter
Copy link
Copy Markdown
Contributor Author

@beinhaerter There appears to be problems with the checks running on older PRs. Can you please push an empty commit to retrigger tests.

I did an amend and a force push, but that did not seem to help.

@beinhaerter
Copy link
Copy Markdown
Contributor Author

This PR is today open since 5 months. When will it finally be merged?

Is Microsoft still working on this repo? Is it still a good library to use in our projects? Or is it dead and we better look for a replacement?

@beinhaerter
Copy link
Copy Markdown
Contributor Author

This PR is today open since half a year. When will it finally be merged?

Is Microsoft still working on this repo? Is it still a good library to use in our projects? Or is it dead and we better look for a replacement?

@grahamreeds
Copy link
Copy Markdown

grahamreeds commented Sep 5, 2024 via email

@beinhaerter
Copy link
Copy Markdown
Contributor Author

I agree that if a compatibility issue has cropped up and the pull request fixes it then it should be merged.
As for whether you should be using it or something else my question is that if it does what you want it to do does it need to be actively worked on?

I don't expect that new features are added. I know GSL implements what the Core Guidelines require. So there is no need for active development aside any bug fixes.
As you said, I do expect that fixes get merged in a timely manner. This helps all users of the GSL.

Speaking as a contributor I can say that I try to help make GSL better, here I try to help others that ran into the clang build problem. The fix is short, so not much time is required to review and merge (except the CI problem), but yet the PR is still not merged and there is no information if and when it will be merged. That is frustrating and reduces my motivation to contribute to the project.

Remember most of the people are busy getting the next version of C++ to the station on time!

That is good to know.

@carsonRadtke
Copy link
Copy Markdown
Member

@beinhaerter Thank you for the contribution!

We understand your frustration and apologize that this PR been open since March. We will be more diligent in responding to bugs and PRs going forward.

@carsonRadtke carsonRadtke merged commit 3275f9c into microsoft:main Oct 12, 2024
@beinhaerter beinhaerter deleted the fix-gcc-build branch October 30, 2024 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants