Windows CI TCL Fixups#1007
Merged
Merged
Conversation
for more information, see https://pre-commit.ci
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR addresses Windows CI failures related to Tcl/Tk library path detection by implementing a workaround for Python issue #111754. The changes add runtime detection and configuration of Tcl/Tk library paths on Windows systems.
- Adds Python-based Tcl/Tk path detection in test configuration
- Adds PowerShell-based Tcl/Tk path logging in CI workflow
- Includes diagnostic logging to help troubleshoot path resolution issues
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| mlos_viz/mlos_viz/tests/conftest.py | Adds Windows-specific workaround to detect and set TCL_LIBRARY, TK_LIBRARY, and TIX_LIBRARY environment variables at test runtime |
| .github/workflows/windows.yml | Adds PowerShell commands to detect Tcl/Tk paths during conda environment setup and adds diagnostic logging step |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
motus
approved these changes
Oct 23, 2025
motus
left a comment
Member
There was a problem hiding this comment.
looks good, modulo copilot comments
bpkroth
added a commit
that referenced
this pull request
Oct 23, 2025
# Pull Request ## Title Capture pytest conftest warnings ______________________________________________________________________ ## Description Followup to #1007. Copilot suggestions were correct. The `logger.warning()` messages generated in `__init__.py` and `conftest.py` are captured, but not emitted by default when *per-test* captures are done. This switches those calls to `UserWarnings` so they are always captured. This was the only location I could find for those. Additionally, I adjust some checks for the `docker.sock` on Windows to avoid some warnings. ______________________________________________________________________ ## Type of Change - 🛠️ Bug fix - 🧪 Tests ______________________________________________________________________ ## Testing Manual. ______________________________________________________________________ --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Title
Windows CI TCL Fixups
Description
test_dabl_plot.py::test_dabl_plot - _tkinter.TclError: Can't find a usable init.tcl#1004Type of Change
Testing