feat(reader): remove ParseNode infrastructure#2852
Merged
Conversation
6526d29 to
a2858a9
Compare
Refactor OpenAPI parsing to use System.Text.Json JsonNode APIs directly with explicit ParsingContext propagation, replacing the ParseNode wrapper hierarchy. Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
e2ad32e to
0fec6aa
Compare
Code Coverage OverviewLanguages: C# C# / code-coverage/dotnetThe overall coverage in the branch remains at 42%, unchanged from the branch. Show a code coverage summary of the most impacted files.
Updated |
gavinbarron
reviewed
May 29, 2026
gavinbarron
left a comment
Contributor
There was a problem hiding this comment.
most of the comments about dicards/casing and unused parameters apply broadly.
Although you have explained the unused parameters in a side chat, so disregard those comments
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Signed-off-by: Vincent Biret <[email protected]>
|
gavinbarron
approved these changes
May 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Benchmark Comparison vs Vincent Biret's Last Update (eb1258a)
Hardware difference:
Results comparison (Vincent → Current):
Gen0/Gen1 GC collections: Similar or slightly lower across all benchmarks.
Key takeaway: The refactored code shows significant improvements in both execution time (30-45% faster) and memory allocation (15-50% less). However, note this is not an apples-to-apples comparison due to different hardware (ARM vs x64) and runtime versions. For a true performance assessment, you'd need to rerun Vincent's baseline commit on the same Snapdragon X hardware.
Validation