Remove unused ConcRT wrappers #1325
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now we don't need to include ConcRT headers. awint.hpp supersedes Windows.h. exception includes yvals.h which includes crtdefs.h; there appears to be no reason to include crtdefs.h directly here. We no longer need to suppress warnings 4201 and 4324 here. This doesn't affect the size of the release DLL. It decreases the size of the debug DLL on x86 by 512 bytes (from 731,136 bytes down to 730,624 bytes).
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
CaseyCarter
approved these changes
Sep 29, 2020
cbezault
approved these changes
Sep 29, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to @AlexGuteniev's #1194 - now that we've had successful GitHub/MSVC builds with the
static_asserts, it's safe to remove the unusedstl_MEOW_concrtclass definitions.Now we don't need to include ConcRT headers.
awint.hppsupersedesWindows.h.exceptionincludesyvals.hwhich includescrtdefs.h; there appears to be no reason to includecrtdefs.hdirectly here.We no longer need to suppress warnings 4201 and 4324 here.
This doesn't affect the size of the release DLL. It decreases the size of the debug DLL on x86 by 512 bytes (from 731,136 bytes down to 730,624 bytes).