<bit>: popcount() utilizes cnt instruction on arm64
#2127
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Alex Guteniev <[email protected]>
<bit>: popcount() utilizes cnt instruction on arm64
Co-authored-by: Alex Guteniev <[email protected]>
AlexGuteniev
suggested changes
Aug 16, 2021
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
AlexGuteniev
approved these changes
Aug 16, 2021
StephanTLavavej
requested changes
Aug 20, 2021
barcharcraz
suggested changes
Aug 25, 2021
barcharcraz
approved these changes
Aug 27, 2021
StephanTLavavej
approved these changes
Sep 8, 2021
Member
|
@fsb4000 Thanks! I've pushed a merge with Also FYI @barcharcraz @AlexGuteniev. |
Member
|
I'm mirroring this to the MSVC-internal repo now. Please notify me if any further changes are pushed. |
Member
|
Thanks for improving ARM64 codegen! 🦾 🚀 ✔️ |
3 tasks
PeterJohnson
added a commit
to wpilibsuite/opencv
that referenced
this pull request
Aug 29, 2023
MSVC on arm64 doesn't have a __popcnt intrinsic. Use NEON instructions instead (core implementation from microsoft/STL#2127).
PeterJohnson
added a commit
to PeterJohnson/openjpeg
that referenced
this pull request
Sep 7, 2023
Use NEON instructions for ARM64 (implementation based on microsoft/STL#2127). Godbolt output here: https://godbolt.org/z/q7GPTqT14
rouault
pushed a commit
to uclouvain/openjpeg
that referenced
this pull request
Dec 9, 2023
Use NEON instructions for ARM64 (implementation based on microsoft/STL#2127). Godbolt output here: https://godbolt.org/z/q7GPTqT14
asmorkalov
pushed a commit
to opencv/opencv
that referenced
this pull request
Dec 10, 2023
ht_dec.c: Improve MSVC arm64 popcount performance #24205 Use NEON instructions for ARM64 (implementation based on microsoft/STL#2127, which is Apache licensed). Godbolt output here: https://godbolt.org/z/q7GPTqT14 Related patch to openjpeg: uclouvain/openjpeg#1479 ### Pull Request Readiness Checklist - [x] I agree to contribute to the project under Apache 2 License. - [x] To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV - [x] The PR is proposed to the proper branch
thewoz
pushed a commit
to thewoz/opencv
that referenced
this pull request
May 29, 2024
ht_dec.c: Improve MSVC arm64 popcount performance opencv#24205 Use NEON instructions for ARM64 (implementation based on microsoft/STL#2127, which is Apache licensed). Godbolt output here: https://godbolt.org/z/q7GPTqT14 Related patch to openjpeg: uclouvain/openjpeg#1479 ### Pull Request Readiness Checklist - [x] I agree to contribute to the project under Apache 2 License. - [x] To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV - [x] The PR is proposed to the proper branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1924
I didn't test it.
godbolt: https://godbolt.org/z/zj3ojEeaM