Fix constexpr vector again #2161
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CaseyCarter
suggested changes
Aug 26, 2021
CaseyCarter
approved these changes
Sep 2, 2021
Member
StephanTLavavej
left a comment
There was a problem hiding this comment.
LGTM, I'll push trivial style changes.
StephanTLavavej
approved these changes
Sep 3, 2021
d64ba6b to
102e358
Compare
CaseyCarter
suggested changes
Sep 7, 2021
Co-authored-by: Casey Carter <[email protected]>
CaseyCarter
approved these changes
Sep 8, 2021
StephanTLavavej
approved these changes
Sep 8, 2021
Member
|
I'm mirroring this to the MSVC-internal repo now. Please notify me if any further changes are pushed. |
Member
|
Thanks for squashing this bug and improving the test coverage! 🐜 💥 😸 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This expands the allocator aware test to also run at compile time and fixes the one bug they found