Toolset update: VS 2022 17.1 Preview 4, ARM64EC #2496
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CaseyCarter
approved these changes
Jan 21, 2022
This was "EDG rejects `hash<optional<const B>>` called with `optional<B>`".
This was "Standard Library Header Units: Adding `template <int = 0>` to `vformat()` emits warnings C4265 and C4365".
This is "Standard Library Header Units: #pragma warning doesn't always suppress warnings in templates".
6d033fb to
061da5c
Compare
c19b306 to
a65f230
Compare
This comment has been minimized.
This comment has been minimized.
6f56111 to
2fc770b
Compare
2fc770b to
bdb6c2b
Compare
barcharcraz
approved these changes
Jan 26, 2022
Contributor
barcharcraz
left a comment
There was a problem hiding this comment.
format stuff looks good (as do other changes, however I spent more attention on format stuff)
CaseyCarter
approved these changes
Jan 26, 2022
Member
Author
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tools/move_only_function_specializationstotools/scripts.move_only_function_specializations.py.<functional>accordingly.move_only_function_specializations.pyexplaining what it does - even though the filename and code are fairly self-explanatory, as we accumulate scripts, it will be helpful for each of them to briefly mention what they do, so we don't need to deduce their intent from their code.tools/scripts/print_failures.py.FAILandXPASStests, then decoding their JSON with search-and-replace (replacing CRLFs and LFs with newlines, unescaping double quotes and backslashes).P0220R1_optional/test.cpp.hash<optional<const B>>called withoptional<B>".subrange.<format>.template <int = 0>tovformat()emits warnings C4265 and C4365".<format>'s use offill_n.'0'can convertchartowchar_t._CharT{'0'}forms the same type, avoiding the warning.<format>.#pragma warningdoesn't always suppress warnings in templates", which @cdacamar has fixed in VS 2022 17.2 Preview 2.chartochar/wchar_tand silencing the warnings, we can use a function object totransform()with astatic_cast. This is more elegant than silencing warnings, and should result in identical release codegen. (Debug mode has more function calls, but avoiding them isn't all-important.)ranges::transform()can directly takestring_view.create-vmss.ps1: Allow QUIC, renumber priorities.'Microsoft.VisualStudio.Component.VC.Tools.ARM64EC'for Add arm64EC pipeline. Disable all SSE usage for ARM64EC #2491.create-vmss.ps1: Also set the Azure CLI subscription.create-vmss.ps1: Use member enumeration and the-incontainment operator, makingFind-ResourceGroupNameCollisionunnecessary.'THHmm'to VMSS names.-1,-2, etc. suffix logic as it's theoretically needed, although in practice it should never appear. (Note that I tested the suffix logic changes before adding these timestamp changes.)vmss-config.jsonandvmss-protected.jsonanymore!--https-only, exactly following the documentation. (I think--https-onlymight have been the actual fix, but I didn't confirm that.)'__DIAGNOSTIC_STORAGE_ACCOUNT__'and'__VM_OR_VMSS_RESOURCE_ID__'invmss-config.json, following the documentation. (I wasn't previously instructed that this was necessary, but in retrospect these strings are obviously placeholders.)--protected-settings, avoiding saving the SAS token to disk. I'm leaving/azure-devops/vmss-protected.jsonmentioned in.gitignore.vmss-config.jsonis too big to pass on the command line, so it must be saved to a file.create-vmss.ps1: UseOut-Nullinstead of ignored variables.README.md.