Thanks to visit codestin.com
Credit goes to github.com

Skip to content

<ranges> Implement P2442R1 slide_view #2670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
StephanTLavavej merged 12 commits into from
May 17, 2022
Merged

<ranges> Implement P2442R1 slide_view #2670

StephanTLavavej merged 12 commits into from
May 17, 2022

Conversation

@miscco
Copy link
Contributor

@miscco miscco commented Apr 25, 2022 •
edited by StephanTLavavej
Loading

This implements slide_view which is one half of P2442R1

given that this is already a considerable amount of code I thought it best to split it up

Partially fixes #2539

@miscco miscco requested a review from a team as a code owner April 25, 2022 21:37
@StephanTLavavej StephanTLavavej added ranges C++20/23 ranges cxx23 C++23 feature labels Apr 26, 2022
cpplearner
cpplearner reviewed Apr 26, 2022
View reviewed changes
@strega-nil-ms strega-nil-ms self-assigned this May 6, 2022
@strega-nil-ms
Copy link
Contributor

strega-nil-ms commented May 6, 2022

Given that I'm looking at chunk_view (#2685) I've assigned myself to this one too

strega-nil-ms
strega-nil-ms previously requested changes May 6, 2022
View reviewed changes
Copy link
Contributor

@strega-nil-ms strega-nil-ms left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

finished checking ranges and yvals_core; will take a look at tests on Monday Tuesday

strega-nil-ms
strega-nil-ms reviewed May 9, 2022
View reviewed changes
@strega-nil-ms strega-nil-ms dismissed their stale review May 9, 2022 14:34

Out-of-date

@strega-nil-ms strega-nil-ms removed their assignment May 12, 2022
StephanTLavavej
StephanTLavavej reviewed May 13, 2022
View reviewed changes
@StephanTLavavej

This comment was marked as resolved.

Sign in to view
@StephanTLavavej
Copy link
Member

StephanTLavavej commented May 14, 2022

After comparing #2685's last round of feedback to this PR, I pushed changes to rename to _Base_iterator and fix the strengthening on _Iterator(_Iterator<!_Const> _Other) to match the conversion that it's performing: is_nothrow_constructible_v<_Base_iterator, typename _Iterator<!_Const>::_Base_iterator>.

@StephanTLavavej
Copy link
Member

StephanTLavavej commented May 16, 2022

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

StephanTLavavej added a commit to StephanTLavavej/STL that referenced this pull request May 16, 2022
@StephanTLavavej
microsoftGH-2670
6afdadc
@StephanTLavavej StephanTLavavej merged commit dffb7ad into microsoft:main May 17, 2022
@StephanTLavavej
Copy link
Member

StephanTLavavej commented May 17, 2022

Thanks for implementing the first half of this ranges feature!

🎉 😸 🎉

@StephanTLavavej StephanTLavavej mentioned this pull request May 17, 2022
Closed
@miscco miscco deleted the views_slide branch May 17, 2022 06:51
fsb4000 pushed a commit to fsb4000/STL that referenced this pull request Aug 13, 2022
@miscco @strega-nil-ms
@StephanTLavavej @fsb4000
<ranges> Implement P2442R1 slide_view (microsoft#2670)
ad5e5d7 
Co-authored-by: nicole mazzuca <[email protected]>
Co-authored-by: Stephan T. Lavavej <[email protected]>
@JMazurkiewicz JMazurkiewicz mentioned this pull request Feb 12, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@StephanTLavavej StephanTLavavej StephanTLavavej approved these changes

+2 more reviewers

@cpplearner cpplearner cpplearner left review comments

@strega-nil-ms strega-nil-ms strega-nil-ms approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@StephanTLavavej StephanTLavavej

Labels

cxx23 C++23 feature ranges C++20/23 ranges

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

P2442R1 Windowing Range Adaptors: views::chunk, views::slide

5 participants

@miscco @strega-nil-ms @StephanTLavavej @cpplearner @CaseyCarter