Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Change an error message in <__msvc_cxx_stdatomic.hpp> #3192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
StephanTLavavej merged 1 commit into from
Nov 11, 2022
Merged

Change an error message in <__msvc_cxx_stdatomic.hpp> #3192

StephanTLavavej merged 1 commit into from
Nov 11, 2022

Conversation

@fsb4000
Copy link
Contributor

@fsb4000 fsb4000 commented Nov 5, 2022

Fixes #3184

@fsb4000 fsb4000 requested a review from a team as a code owner November 5, 2022 14:31
@StephanTLavavej StephanTLavavej added the documentation Related to documentation or comments label Nov 6, 2022
barcharcraz
barcharcraz approved these changes Nov 8, 2022
View reviewed changes
Copy link
Contributor

@barcharcraz barcharcraz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@StephanTLavavej StephanTLavavej self-assigned this Nov 11, 2022
@StephanTLavavej
Copy link
Member

StephanTLavavej commented Nov 11, 2022

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit 29ac086 into microsoft:main Nov 11, 2022
@StephanTLavavej
Copy link
Member

StephanTLavavej commented Nov 11, 2022

Thanks for clarifying this error message for bad kitties who jump up on the table where they're not allowed and include internal C++ headers in C mode! 😼 😹 🎉

@fsb4000 fsb4000 deleted the fix3184 branch November 12, 2022 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@StephanTLavavej StephanTLavavej StephanTLavavej approved these changes

+2 more reviewers

@barcharcraz barcharcraz barcharcraz approved these changes

@strega-nil-ms strega-nil-ms strega-nil-ms approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@StephanTLavavej StephanTLavavej

Labels

documentation Related to documentation or comments

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

<__msvc_cxx_stdatomic.hpp>: C error message is confusing

4 participants

@fsb4000 @StephanTLavavej @barcharcraz @strega-nil-ms