P2602R2 Poison Pills Are Too Toxic #3215
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Title and comment: it's P2602R2, not P2606. |
Consistently annotate throughout with `// intentional ADL` and `// Block unqualified name lookup`. Drive-by: * Consistently use east `const` in `P0896R4_ranges_machinery`. * Feeature-test macro test fixes: * `__cpp_lib_concepts` should not be defined in sub-C++20-modes * `__cpp_lib_ranges` should not be defined in sub-C++20 modes even if `__cpp_lib_concepts` is defined. (This is redundant with the previous fix, but it doesn't hurt anything.) Fixes microsoft#3209
barcharcraz
reviewed
Nov 17, 2022
StephanTLavavej
requested changes
Nov 17, 2022
tests/std/tests/VSO_0157762_feature_test_macros/test.compile.pass.cpp
Outdated
Show resolved
Hide resolved
strega-nil-ms
approved these changes
Nov 30, 2022
barcharcraz
approved these changes
Dec 1, 2022
StephanTLavavej
approved these changes
Dec 5, 2022
Member
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
Member
💀 💊 ☣️ 📉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace poison pills with unqualified name lookup blocks per P2602R2.
Consistently annotate throughout with
// intentional ADLand// Block unqualified name lookup.Drive-by:
__cpp_lib_conceptsshould not be defined in sub-C++20-modes__cpp_lib_rangesshould not be defined in sub-C++20 modes even if__cpp_lib_conceptsis defined. (This is redundant with the previous fix, but it doesn't hurt anything.)Fixes #3209
For review purposes: P2602R2.zip