Don't rely on SSO zeroing in basic_string::_Construct
#3235
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... or we will have horrible failures when linking with object files from 17.3. `_Construct` must null-terminate the string itself on all control paths. I've added a comment to the `_String_val::_Bxty` constructor directing us not to rely on the semantic changes introduced in 17.4 to avoid regressing.
StephanTLavavej
approved these changes
Nov 17, 2022
Member
|
Thanks, looks good to me. This also makes the small case use consistent patterns with the large case below. |
Member
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
Member
|
Thanks for investigating and fixing this ABI break! 🙀 🕵️ 😻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... or we will have horrible failures when linking with object files from 17.3.
_Constructmust null-terminate the string itself on all control paths. I've added a comment to the_String_val::_Bxtyconstructor directing us not to rely on the semantic changes introduced in 17.4 to avoid regressing.