Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix stl.natvis std::optional<*> #3243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
StephanTLavavej merged 4 commits into from
Dec 6, 2022
Merged

fix stl.natvis std::optional<*> #3243

StephanTLavavej merged 4 commits into from
Dec 6, 2022

Conversation

@strega-nil-ms
Copy link
Contributor

@strega-nil-ms strega-nil-ms commented Nov 22, 2022

optional<*> originally used <Intrinsic>s for _Has_value and _Value; however, apparently VS doesn't like doing custom visualizers for <Intrinsic> calls.

Fixes VSO-1631025 / DevCom-10155697

@strega-nil
fix stl.natvis std::optional<*>
4100330 
`optional<*>` originally used `<Intrinsic>`s for `_Has_value` and `_Value`;
however, apparently VS doesn't like doing custom visualizers for
`<Intrinsic>` calls.

Fixes VSO-1631025 / DevCom-10155697
@strega-nil-ms strega-nil-ms requested a review from a team as a code owner November 22, 2022 22:45
@strega-nil-ms strega-nil-ms added the visualizer How the VS debugger displays STL types label Nov 22, 2022
cpplearner
cpplearner reviewed Nov 22, 2022
View reviewed changes
strega-nil-ms
strega-nil-ms commented Nov 23, 2022
View reviewed changes
@StephanTLavavej StephanTLavavej self-assigned this Dec 5, 2022
@StephanTLavavej
Copy link
Member

StephanTLavavej commented Dec 5, 2022

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit aeed392 into microsoft:main Dec 6, 2022
@StephanTLavavej
Copy link
Member

StephanTLavavej commented Dec 6, 2022

Thanks for fixing this visualizer! 🪐 🔭 👁️

@strega-nil-ms strega-nil-ms deleted the fix-optional-visualizer branch December 19, 2022 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@StephanTLavavej StephanTLavavej StephanTLavavej approved these changes

+2 more reviewers

@cpplearner cpplearner cpplearner left review comments

@CaseyCarter CaseyCarter CaseyCarter approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@StephanTLavavej StephanTLavavej

Labels

visualizer How the VS debugger displays STL types

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@strega-nil-ms @StephanTLavavej @CaseyCarter @cpplearner @strega-nil