Fix for std::numeric_limits<std::_Signed128>::is_signed
#3291
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CaseyCarter
approved these changes
Dec 15, 2022
Contributor
CaseyCarter
left a comment
There was a problem hiding this comment.
Thanks for fixing my mistake!
strega-nil-ms
approved these changes
Dec 16, 2022
Contributor
strega-nil-ms
left a comment
There was a problem hiding this comment.
Thanks for noticing!
Contributor
Author
|
@microsoft-github-policy-service agree |
StephanTLavavej
approved these changes
Dec 16, 2022
Member
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
Member
|
Thanks for fixing this bug, and congratulations on your first microsoft/STL commit! 🎉 😻 🚀 This will ship in VS 2022 17.6 Preview 2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I've noticed that the MSVC's STL provides
std::numeric_limitstemplate specializationfor the
std::_Signed128(a type which models thesigned-integer-classconcept) slightly incorrectly,that is the
std::numeric_limits<std::_Signed128>::is_signedisfalseinstead oftrue:This change fixes that issue and adds a couple of compile-time checks
verifying that the
std::numeric_limits<std::_Signed128>is properly specialized.